-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick start: add alternative content for non-serving viewers #3871
Labels
🌊 C++ API
C/C++ API specific
🐍 Python API
Python logging API
🦀 Rust API
Rust logging API
ui
concerns graphical user interface
Milestone
Comments
abey79
added
🐍 Python API
Python logging API
ui
concerns graphical user interface
🦀 Rust API
Rust logging API
🌊 C++ API
C/C++ API specific
labels
Oct 16, 2023
4 tasks
abey79
added a commit
that referenced
this issue
Oct 17, 2023
### What This PR lays the basis for in-app "Quick Start" guides. After a failed attempt to use `re_sdk` from `re_viewer` (can't target wasm), this PR builds on recent `StoreDb` API improvements to create "quick start" recordings from scratch. This involves: - adding a nice `StoreDb::from_info_and_rows()` helper function - adding `SystemCommand::LoadStoreDb(StoreDb)` - adding `StoreSource::Viewer` (for recordings generated from the viewer itself) - some helper functions in `welcome_page.rs` This PR also introduces a draft for the (native-only) Python and Rust Quick Starts, and placeholder for the other languages. To address (in follow-up PR): - markdown formatting issue where H1 appears smaller than H2 (current work around: skip on using H1) - #3612 - specialise Quick Start for non-server Viewers - #3871 - write Quick Start for C++: - #3870 - markdown formatting issue: - lampsitter/egui_commonmark#19 <img width="1315" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/232b4a79-7917-4978-95d1-94474142da94"> * Fixes #3095 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3813) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/3813) - [Docs preview](https://rerun.io/preview/9c7ebbf37a890b5d09941102a4d7c3a35f53f277/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/9c7ebbf37a890b5d09941102a4d7c3a35f53f277/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/) --------- Co-authored-by: Emil Ernerfeldt <[email protected]>
4 tasks
abey79
added a commit
that referenced
this issue
Oct 19, 2023
### What By default, the Quick Start guides show instructions that will send a recording to the current viewer. This is only possible if the viewer accepts TPC connection (which is not the case of Web-based viewers). This PR adds a varient for the guides that will instead spawn a local viewer whenever TCP connections aren't accepted. * Fixes #3871 In a connection-accepting viewer: <img width="1291" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/f4ffbb87-c01c-412f-b0b5-ac2df5c16bb8"> In a web viewer: <img width="1185" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/c5106daa-babb-4bbd-9c30-3a2aee9c59c5"> ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3912) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/3912) - [Docs preview](https://rerun.io/preview/5d04ce8296947cab55c1373990037f7266a5834c/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/5d04ce8296947cab55c1373990037f7266a5834c/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
emilk
added a commit
that referenced
this issue
Jan 23, 2024
### What This is so we can test things out before the next release, and also get in some new egui features for the plot aggregator and drag-and-drop. * Closes #4716 * Closes #4794 ### TODO * [x] Fix hovering ListItems in blueprint panel ### wgpu changelog https://github.com/gfx-rs/wgpu/blob/trunk/CHANGELOG.md#v0190-2024-01-17 ### relevant egui changelog (so far) #### eframe * Keep `ViewportInfo::maximized` and `minimized` up-to-date on Windows [#3831](emilk/egui#3831) (thanks [@rustbasic](https://github.com/rustbasic)!) * Update wgpu to 0.19 [#3824](emilk/egui#3824) * Fix: handle `IconData::default()` without crashing [#3842](emilk/egui#3842) #### egui_extras * Fix unwraps in SVG scaling [#3826](emilk/egui#3826) (thanks [@amPerl](https://github.com/amPerl)!) * Update to ehttp 0.4 [#3834](emilk/egui#3834) #### egui_plot * Make `egui_plot::PlotMemory` public [#3871](emilk/egui#3871) #### egui * Selectable text in Labels [#3814](emilk/egui#3814) * `ComboBox`: add builder method for height [#3001](emilk/egui#3001) (thanks [@hinto-janai](https://github.com/hinto-janai)!) * Add keys `?`, `/`, `|` [#3820](emilk/egui#3820) * Fix clickable widgets blocking scrolling on touch screens [#3815](emilk/egui#3815) (thanks [@lucasmerlin](https://github.com/lucasmerlin)!) * Fix `stable_dt` [#3832](emilk/egui#3832) * Bug Fix : `Response::is_pointer_button_down_on` is now false the frame the button is released [#3833](emilk/egui#3833) (thanks [@rustbasic](https://github.com/rustbasic)!) * Use runtime knowledge of OS for OS-specific text editing [#3840](emilk/egui#3840) * Refactor: move text selection logic to own module [#3843](emilk/egui#3843) * Fix: dragging to above/below a `TextEdit` or `Label` will select text to begin/end [#3858](emilk/egui#3858) * Add `Response::contains_pointer` [#3859](emilk/egui#3859) * Always set `response.hovered` to false when dragging another widget [#3860](emilk/egui#3860) * Add `Align2::anchor_size` [#3863](emilk/egui#3863) * Add `Context::debug_text` [#3864](emilk/egui#3864) #### epaint * Add `Align2::anchor_size` [#3863](emilk/egui#3863) ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/4885/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/4885/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/4885/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4885) - [Docs preview](https://rerun.io/preview/eb1bce846c3adb29b99d04018b002475994ad213/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/eb1bce846c3adb29b99d04018b002475994ad213/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) --------- Co-authored-by: Andreas Reich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🌊 C++ API
C/C++ API specific
🐍 Python API
Python logging API
🦀 Rust API
Rust logging API
ui
concerns graphical user interface
When the Viewer doesn't accept TCP connection, the in-app Quick Guides should not suggest the "connect" method.
The text was updated successfully, but these errors were encountered: