-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to wgpu 0.19 and latest egui
trunk
#4885
Conversation
Size changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI part looks good to me 👍🏻 (I haven't checked the renderer part.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -108,11 +97,8 @@ pub fn build( | |||
"--target-dir", | |||
target_wasm_dir.as_str(), | |||
"--no-default-features", | |||
"--features=analytics", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, if you look closely this moved in from the if/else further down - both branches enabled the analytics feature
What
This is so we can test things out before the next release, and also get in some new egui features for the plot aggregator and drag-and-drop.
TODO
wgpu changelog
https://github.com/gfx-rs/wgpu/blob/trunk/CHANGELOG.md#v0190-2024-01-17
relevant egui changelog (so far)
eframe
ViewportInfo::maximized
andminimized
up-to-date on Windows #3831 (thanks @rustbasic!)IconData::default()
without crashing #3842egui_extras
egui_plot
egui_plot::PlotMemory
public #3871egui
ComboBox
: add builder method for height #3001 (thanks @hinto-janai!)?
,/
,|
#3820stable_dt
#3832Response::is_pointer_button_down_on
is now false the frame the button is released #3833 (thanks @rustbasic!)TextEdit
orLabel
will select text to begin/end #3858Response::contains_pointer
#3859response.hovered
to false when dragging another widget #3860Align2::anchor_size
#3863Context::debug_text
#3864epaint
Align2::anchor_size
#3863Checklist
main
build: app.rerun.ionightly
build: app.rerun.io