Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to wgpu 0.19 and latest egui trunk #4885

Merged
merged 21 commits into from
Jan 23, 2024
Merged

Update to wgpu 0.19 and latest egui trunk #4885

merged 21 commits into from
Jan 23, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Jan 23, 2024

What

This is so we can test things out before the next release, and also get in some new egui features for the plot aggregator and drag-and-drop.

TODO

  • Fix hovering ListItems in blueprint panel

wgpu changelog

https://github.com/gfx-rs/wgpu/blob/trunk/CHANGELOG.md#v0190-2024-01-17

relevant egui changelog (so far)

eframe

  • Keep ViewportInfo::maximized and minimized up-to-date on Windows #3831 (thanks @rustbasic!)
  • Update wgpu to 0.19 #3824
  • Fix: handle IconData::default() without crashing #3842

egui_extras

egui_plot

  • Make egui_plot::PlotMemory public #3871

egui

  • Selectable text in Labels #3814
  • ComboBox: add builder method for height #3001 (thanks @hinto-janai!)
  • Add keys ?, /, | #3820
  • Fix clickable widgets blocking scrolling on touch screens #3815 (thanks @lucasmerlin!)
  • Fix stable_dt #3832
  • Bug Fix : Response::is_pointer_button_down_on is now false the frame the button is released #3833 (thanks @rustbasic!)
  • Use runtime knowledge of OS for OS-specific text editing #3840
  • Refactor: move text selection logic to own module #3843
  • Fix: dragging to above/below a TextEdit or Label will select text to begin/end #3858
  • Add Response::contains_pointer #3859
  • Always set response.hovered to false when dragging another widget #3860
  • Add Align2::anchor_size #3863
  • Add Context::debug_text #3864

epaint

  • Add Align2::anchor_size #3863

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@emilk emilk added 🔺 re_renderer affects re_renderer itself dependencies concerning crates, pip packages etc include in changelog egui Requires egui/eframe work labels Jan 23, 2024
Copy link

github-actions bot commented Jan 23, 2024

Size changes

Name main 4885/merge Change
JS 111.52 kiB 139.41 kiB +25.01%

@Wumpf Wumpf self-requested a review January 23, 2024 09:21
@emilk emilk marked this pull request as draft January 23, 2024 09:27
@emilk emilk requested a review from abey79 January 23, 2024 09:50
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI part looks good to me 👍🏻 (I haven't checked the renderer part.)

@emilk emilk marked this pull request as ready for review January 23, 2024 13:20
Copy link
Member Author

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -108,11 +97,8 @@ pub fn build(
"--target-dir",
target_wasm_dir.as_str(),
"--no-default-features",
"--features=analytics",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated change?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, if you look closely this moved in from the if/else further down - both branches enabled the analytics feature

crates/re_renderer/src/config.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@emilk emilk merged commit bd64926 into main Jan 23, 2024
40 of 41 checks passed
@emilk emilk deleted the emilk/update-wgpu-egui branch January 23, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies concerning crates, pip packages etc egui Requires egui/eframe work include in changelog 🔺 re_renderer affects re_renderer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Camera spins unevenly at <=100 FPS rendering speed
3 participants