Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app.rerun.io should show the rrd url in the path #2391

Closed
emilk opened this issue Jun 12, 2023 · 0 comments · Fixed by #2455
Closed

app.rerun.io should show the rrd url in the path #2391

emilk opened this issue Jun 12, 2023 · 0 comments · Fixed by #2455
Labels
examples Issues relating to the Rerun examples 🕸️ web regarding running the viewer in a browser

Comments

@emilk
Copy link
Member

emilk commented Jun 12, 2023

No description provided.

@emilk emilk added 🕸️ web regarding running the viewer in a browser examples Issues relating to the Rerun examples labels Jun 12, 2023
@jprochazk jprochazk mentioned this issue Jun 16, 2023
Merged
2 tasks
jprochazk added a commit that referenced this issue Jun 16, 2023
@jprochazk
Show hidden url search param in app.rerun.io (#2455)
60ac935 
<!--
Open the PR up as a draft until you feel it is ready for a proper
review.

Do not make PR:s from your own `main` branch, as that makes it difficult
for reviewers to add their own fixes.

Add any improvements to the branch as new commits to make it easier for
reviewers to follow the progress. All commits will be squashed to a
single commit once the PR is merged into `main`.

Make sure you mention any issues that this PR closes in the description,
as well as any other related issues.

To get an auto-generated PR description you can put "copilot:summary" or
"copilot:walkthrough" anywhere.
-->

### What

Fixes #2391

Upon loading `app.rerun.io` sets the `url` search param if it is not
already set

### Checklist
* [ ] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [ ] I've included a screenshot or gif (if applicable)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2455

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/a0fa005/docs
Examples preview: https://rerun.io/preview/a0fa005/examples
<!-- pr-link-docs:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
examples Issues relating to the Rerun examples 🕸️ web regarding running the viewer in a browser
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show hidden url search param in app.rerun.io rerun-io/rerun
1 participant
@emilk