Skip to content

Commit

Permalink
Show hidden url search param in app.rerun.io (#2455)
Browse files Browse the repository at this point in the history
<!--
Open the PR up as a draft until you feel it is ready for a proper
review.

Do not make PR:s from your own `main` branch, as that makes it difficult
for reviewers to add their own fixes.

Add any improvements to the branch as new commits to make it easier for
reviewers to follow the progress. All commits will be squashed to a
single commit once the PR is merged into `main`.

Make sure you mention any issues that this PR closes in the description,
as well as any other related issues.

To get an auto-generated PR description you can put "copilot:summary" or
"copilot:walkthrough" anywhere.
-->

### What

Fixes #2391

Upon loading `app.rerun.io` sets the `url` search param if it is not
already set

### Checklist
* [ ] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [ ] I've included a screenshot or gif (if applicable)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2455

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/a0fa005/docs
Examples preview: https://rerun.io/preview/a0fa005/examples
<!-- pr-link-docs:end -->
  • Loading branch information
jprochazk authored Jun 16, 2023
1 parent 8f55136 commit 60ac935
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion web_viewer/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,9 @@
const rrd_file = url_params.get('file') || 'colmap_fiat.rrd';

// Normalize the extra slashes from the url
return (data_path + rrd_file).replace(/\/{2,}/g, '/');
const normalized = (data_path + rrd_file).replace(/\/{2,}/g, '/');
window.location.search = `?url=${normalized}`;
return normalized;
}

function on_wasm_error(error) {
Expand Down

0 comments on commit 60ac935

Please sign in to comment.