Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multilabel segmentations logging #1544

Open
cortwave opened this issue Mar 9, 2023 · 1 comment
Open

Multilabel segmentations logging #1544

cortwave opened this issue Mar 9, 2023 · 1 comment
Labels
enhancement New feature or request 🍏 primitives Relating to Rerun primitives

Comments

@cortwave
Copy link

cortwave commented Mar 9, 2023

Is your feature request related to a problem? Please describe.
Now you can log only one label per pixel using the log_segmentation_image method. Sometimes we need to have more than one class per pixel (multilabel segmentation). As a workaround, we can log each label as a separate mask. But it looks like a dirty hack and a big disadvantage is that you can't display more than 1 mask simultaneously in the viewer.

Describe the solution you'd like
It'll be cool to have a method that allows logging multichannel segmentation mask tensor with binary mask in each channel. To display the intersection of different labels we can use the average color of labels in certain pixels.

Describe alternatives you've considered
As an alternative, the issue can be resolved by allowing to display of multiple segmentation masks at the same time. Of course, it's not an elegant way due to big amount of boilerplate code you should write to log multilabel segmentation mask

Additional context
Example how it looks now if we log each label as a separate segmentation mask (viewer can't display all masks together)
image

@cortwave cortwave added enhancement New feature or request 👀 needs triage This issue needs to be triaged by the Rerun team labels Mar 9, 2023
@nikolausWest nikolausWest added 🍏 primitives Relating to Rerun primitives and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Mar 9, 2023
emilk added a commit that referenced this issue Jun 27, 2023
We should make people who file issues feel seen by commenting on them

Example output:

```
#1529 by rasmusgo has 0 comments
#1544 by cortwave has 0 comments
#1571 by pablovela5620 has 0 comments
```
@emilk
Copy link
Member

emilk commented Jun 27, 2023

This sounds quite doable. It is just a matter of reinterpreting the integer as a bit-set rather than an index. I wonder if this state (index or bitset) should be part of the tensor or the annotation context 🤔

emilk added a commit that referenced this issue Jun 28, 2023
### What
We should make people who file issues feel seen by commenting on them

Example output:

```
#1529 by rasmusgo has 0 comments
#1544 by cortwave has 0 comments
#1571 by pablovela5620 has 0 comments
```

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2532

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/e91e000/docs
Examples preview: https://rerun.io/preview/e91e000/examples
<!-- pr-link-docs:end -->
emilk added a commit that referenced this issue Jun 29, 2023
### What
We should make people who file issues feel seen by commenting on them

Example output:

```
#1529 by rasmusgo has 0 comments
#1544 by cortwave has 0 comments
#1571 by pablovela5620 has 0 comments
```

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2532

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/e91e000/docs
Examples preview: https://rerun.io/preview/e91e000/examples
<!-- pr-link-docs:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🍏 primitives Relating to Rerun primitives
Projects
None yet
Development

No branches or pull requests

3 participants