Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerun as a better alternative to imshow #1511

Closed
7 tasks
nikolausWest opened this issue Mar 5, 2023 · 10 comments
Closed
7 tasks

Rerun as a better alternative to imshow #1511

nikolausWest opened this issue Mar 5, 2023 · 10 comments
Labels
enhancement New feature or request 🐍 Python API Python logging API 📺 re_viewer affects re_viewer itself 🦀 Rust API Rust logging API 🎄 tracking issue issue that tracks a bunch of subissues

Comments

@nikolausWest
Copy link
Member

nikolausWest commented Mar 5, 2023

Rerun should become a valid replacement and obvious improvement to using cv2.imshow, plt.imshow, or px.imshow.

This requires (at least):

  • Configurable ranges / (spatial) extent in image and tensor view #1510
  • Optionally show grid on image and tensor views
  • Optionally show axis on image and tensor views
  • Rerun renders inline in Jupyter Notebooks
  • Zoomed in value inspection on hover for tensor views
  • Images in 2D views are special cases of tensor views
  • All image and tensor related blueprint options are settable from the Python and Rust SDKs
@nikolausWest nikolausWest added enhancement New feature or request 🐍 Python API Python logging API 🦀 Rust API Rust logging API 🎄 tracking issue issue that tracks a bunch of subissues 📺 re_viewer affects re_viewer itself labels Mar 5, 2023
@Erol444
Copy link

Erol444 commented Mar 6, 2023

To add to this the list, disabling logging would likely be required as well for runtime applications as well, as otherwise, users would quickly run out of RAM:)

@nikolausWest
Copy link
Member Author

@Erol444: Do you mean just setting the logging SDK to be no-op? That can be done already. See the parameter default_enabled in the init method: https://ref.rerun.io/docs/python/v0.2.0/common/initialization/#rerun.init

@Erol444
Copy link

Erol444 commented Mar 6, 2023

@nikolausWest Is this working as expected, for Python as well? Similar to this issue (& my comments there), it looks like it isn't working, or perhaps there's a memory leak somewhere else. I tried it with default_enabled=False, but it seems like it's still logging:
image

@teh-cmc
Copy link
Member

teh-cmc commented Mar 6, 2023

Can confirm default_enabled is broken in the python bindings at the moment; will push a fix in a moment so that it ships as part of the imminent 0.3.0 release.

In the meantime you can use rr.set_enabled to achieve the same effect, that one still works.

@Erol444
Copy link

Erol444 commented Mar 7, 2023

@teh-cmc but then how do I transfer the image to rr so it displays it? The rr.log_image() doesn't work (I assume as I disabled logging, duh), and rr viewer is just waiting for a connection.

@nikolausWest
Copy link
Member Author

@Erol444: could you give a little more details on what you are trying to achieve? I think I may have originally misinterpreted what you meant by disabling logging.

@Erol444
Copy link

Erol444 commented Mar 8, 2023

Hi @nikolausWest , I just want the live-preview of the image/pointcloud/... without actually saving the history (logging?) by writing these objects into RAM, as otherwise it fills up the whole RAM and slows down. I hope that makes sense!

@nikolausWest
Copy link
Member Author

nikolausWest commented Mar 9, 2023

@Erol444, alright, I understand. We use the name logging for the operation that takes data out of your program and into Rerun (whether that is a .rrd file or the Viewer). That it fills up RAM is based on two separate problems:

We're working on fixing both of these right now.

@nikolausWest
Copy link
Member Author

Not quite a requirement for replacing imshow but this still feels related:

@nikolausWest
Copy link
Member Author

Superseded by #1630

@nikolausWest nikolausWest closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🐍 Python API Python logging API 📺 re_viewer affects re_viewer itself 🦀 Rust API Rust logging API 🎄 tracking issue issue that tracks a bunch of subissues
Projects
None yet
Development

No branches or pull requests

3 participants