Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documents: refactoring work_access_point field #3292

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

zannkukai
Copy link
Contributor

  • Updates document.work_access_point field : rename field 'agent' to
    'creator'.
  • Fixes missing ES mapping for this field.

Co-Authored-by: Renaud Michotte [email protected]

@zannkukai zannkukai self-assigned this Mar 30, 2023
@github-actions github-actions bot added dev: fixtures Fixtures data used for ils.test and ilsdev.test f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: data migration Data migration from a legacy system or a previous version f: search labels Mar 30, 2023
@github-actions github-actions bot added the dev: DB Database structure (models.py) label Apr 4, 2023
@zannkukai zannkukai force-pushed the zan-wap-again branch 2 times, most recently from ae5e996 to 8cb7f00 Compare April 6, 2023 08:13
@zannkukai zannkukai marked this pull request as ready for review April 6, 2023 08:13
Copy link
Contributor

@rerowep rerowep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the new entities preferred_name will be called authorized_access_point?

'conference': False
}
if value.get('a'):
data['name'] = remove_trailing_punctuation(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be preferred_name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rerowep The directives were "No change on "work_access_point" except field author renamed to creator

* Updates `document.work_access_point` field : rename field 'agent' to
  'creator'.
* Fixes missing ES mapping for this field.

Co-Authored-by: Renaud Michotte <[email protected]>
@zannkukai zannkukai merged commit 0a94bbb into rero:US-2434-entity Apr 19, 2023
@zannkukai zannkukai deleted the zan-wap-again branch April 19, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev: DB Database structure (models.py) dev: fixtures Fixtures data used for ils.test and ilsdev.test f: data migration Data migration from a legacy system or a previous version f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: search
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants