Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entity: use entity instead of contribution #941

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Feb 20, 2023

  • Adds a new contribution component.
  • Removes Mef Person et Organisastion typeahead service.
  • Adds Mef typeahead service.
  • Adapts MefTypeahead autocomplete component to allow "concept"
    autocompletion.
  • Adds contribution entity pipe.
  • Removes contribution filter and format pipe.
  • Renames contribution to entity.
  • Uses authorized_access_point.

Co-Authored-by: Bertrand Zuchuat [email protected]
Co-Authored-by: Johnny Mariéthoz [email protected]
Co-Authored-by: Renaud Michotte [email protected]

@Garfield-fr Garfield-fr self-assigned this Feb 20, 2023
@github-actions github-actions bot added f: circulation Concerns the circulation interface or backend f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface f: search f: user management labels Feb 20, 2023
@Garfield-fr Garfield-fr force-pushed the zub-contributions branch 5 times, most recently from bc4061e to c881151 Compare February 20, 2023 14:28
@Garfield-fr Garfield-fr force-pushed the zub-contributions branch 3 times, most recently from cb8e8b3 to a6ae21a Compare April 5, 2023 07:25
@Garfield-fr Garfield-fr changed the title documents: improve contribution format entity: use entity instead of contribution Apr 5, 2023
@Garfield-fr Garfield-fr marked this pull request as ready for review April 5, 2023 07:26
@PascalRepond
Copy link
Contributor

PascalRepond commented Apr 13, 2023

Tests for US-2434-entity

  • In contribution field, the only types accepted should be bf:Person and bf:Organisation
  • In contribution field, the addition of sources and subdivisions should not be possible (only for Subjects)
  • Work access point "link to work" is still available, it should only allow local
    @zannkukai for @PascalRepond : it will be corrected when documents: refactoring work_access_point field rero-ils#3292 will be integrated
  • EDITOR: Adding a MEF subject (person or organisation) to existing subject field results in error "'bf:Person' is not one of ['bf:Topic', 'bf:Place', 'bf:Temporal']."
  • Adding a MEF Agent in the contribution field leads to the same error.
  • In the Import results search, if there is a $0 in the 100/700 fields, in SLSP for example, the contributors doesn't appear as link anymore (but it's ok in the editor).
    @zannkukai : Not linked to this US. Corrected by Peter in this PR : import: fix contribution $ref creation rero-ils#3313
  • Trying to import this record (video recording number = 3545020060155) result in the following error : 'RERO-RAMEAU' is not one of ['bf:Local', 'IdRef', 'GND', 'RERO'].
  • If a MEF entity is used as a subject, it does not appear in the detailed view, nor in the results (ex. : search for "Benavides, Oswald" it does not find the records pid 2000740
    @zannkukai : it's solved by document: linked concept for genreForm field. rero-ils#3315

@zannkukai zannkukai force-pushed the zub-contributions branch 2 times, most recently from 39a03d8 to fa49787 Compare April 18, 2023 13:04
@zannkukai zannkukai changed the base branch from staging to US-Entities April 19, 2023 12:03
* Adds a new contribution component.
* Removes Mef Person et Organisastion typeahead service.
* Adds Mef typeahead service.
* Adds contribution entity pipe.
* Removes contribution filter and format pipe.
* Renames contribution to entity.
* Uses authorized_access_point.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Co-Authored-by: Johnny Mariéthoz <[email protected]>
@zannkukai zannkukai merged commit 8d1f630 into rero:US-Entities Apr 19, 2023
@Garfield-fr Garfield-fr deleted the zub-contributions branch October 10, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: circulation Concerns the circulation interface or backend f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface f: search f: user management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants