Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: write cypress tests to check 0 day checkout #1514

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

AoNoOokami
Copy link
Contributor

@AoNoOokami AoNoOokami commented Nov 27, 2020

  • Adds a test to control that the 'zero day checkout' works correctly.
  • Adds a test to check the creation of a circulation policy.

Co-Authored-by: Alicia Zangger [email protected]

Why are you opening this PR?

To create cypress tests on cipo editor.

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@AoNoOokami AoNoOokami self-assigned this Nov 27, 2020
@AoNoOokami AoNoOokami added the dev: tests For all types of tests: unit tests, e2e (Cypress)... label Nov 27, 2020
@AoNoOokami AoNoOokami added this to the v0.15.0 milestone Nov 27, 2020
@AoNoOokami AoNoOokami force-pushed the zaa-#1887-test-cipo-cypress branch 8 times, most recently from 348740f to 4b66725 Compare December 2, 2020 16:32
@AoNoOokami AoNoOokami mentioned this pull request Dec 4, 2020
7 tasks
@AoNoOokami AoNoOokami force-pushed the zaa-#1887-test-cipo-cypress branch 2 times, most recently from bcf3270 to e12bbfa Compare December 10, 2020 16:37
@AoNoOokami AoNoOokami marked this pull request as ready for review December 10, 2020 17:08
@AoNoOokami AoNoOokami force-pushed the zaa-#1887-test-cipo-cypress branch from e12bbfa to 7196880 Compare December 10, 2020 17:09
@AoNoOokami AoNoOokami modified the milestones: v0.15.0, v1.0.0 Dec 10, 2020
@@ -0,0 +1,85 @@
/// <reference types="Cypress" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it normal the dash between ci and po into the name file ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message proposition:

tests: write cypress tests to check 0 day checkout

* Adds a test to control that the 'zero day checkout' works correctly.
* Adds a test to check the creation of a circulation policy.

@AoNoOokami AoNoOokami force-pushed the zaa-#1887-test-cipo-cypress branch from 7196880 to 403658c Compare December 14, 2020 08:21
@AoNoOokami AoNoOokami changed the title tests: create cypress tests to check 0 day checkout tests: write cypress tests to check 0 day checkout Dec 14, 2020
@AoNoOokami AoNoOokami force-pushed the zaa-#1887-test-cipo-cypress branch 2 times, most recently from 93052d1 to 03cbbe0 Compare December 14, 2020 10:39
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@AoNoOokami AoNoOokami force-pushed the zaa-#1887-test-cipo-cypress branch 2 times, most recently from 1f886ae to 966fdca Compare December 15, 2020 16:20
@AoNoOokami AoNoOokami changed the base branch from dev to v1.0.0 December 16, 2020 10:20
@AoNoOokami AoNoOokami force-pushed the zaa-#1887-test-cipo-cypress branch from 966fdca to b27ad70 Compare December 16, 2020 13:10
* Adds a test to control that the 'zero day checkout' works correctly.
* Adds a test to check the creation of a circulation policy.
* Improves example test.

Co-Authored-by: Alicia Zangger <[email protected]>
@AoNoOokami AoNoOokami force-pushed the zaa-#1887-test-cipo-cypress branch from b27ad70 to a98811d Compare December 16, 2020 14:29
@AoNoOokami AoNoOokami merged commit e64dfc6 into rero:v1.0.0 Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev: tests For all types of tests: unit tests, e2e (Cypress)...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants