Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix templates for cypress tests #469

Merged

Conversation

AoNoOokami
Copy link
Contributor

  • Puts back some id html attribute that were removed. There are needed
    to keep Cypress tests working.

Co-Authored-by: Alicia Zangger [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on rero-ils#<xx>'s PR(s):

  • rero/rero-ils#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@AoNoOokami AoNoOokami self-assigned this Dec 10, 2020
@AoNoOokami AoNoOokami modified the milestones: v0.15.0, v1.0.0 Dec 10, 2020
@iGormilhit iGormilhit added the dev: tests For all types of tests: unit tests, e2e (Cypress)... label Dec 14, 2020
@AoNoOokami AoNoOokami force-pushed the zaa-fix-templates-for-cypress-tests branch 2 times, most recently from f41a9e9 to 59cd031 Compare December 15, 2020 13:03
@AoNoOokami AoNoOokami changed the base branch from dev to v1.0.0 December 16, 2020 10:22
* Puts back some id html attribute that were removed. There are needed
to keep Cypress tests working.

Co-Authored-by: Alicia Zangger <[email protected]>
@AoNoOokami AoNoOokami force-pushed the zaa-fix-templates-for-cypress-tests branch from 59cd031 to 17194f7 Compare December 17, 2020 13:11
@AoNoOokami AoNoOokami removed the request for review from Garfield-fr December 17, 2020 14:22
@AoNoOokami AoNoOokami merged commit 3ad2934 into rero:v1.0.0 Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev: tests For all types of tests: unit tests, e2e (Cypress)...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants