patrons: fix subscriptions renewal problem. #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
force-pushed
the
zan-fix-subscriptions
branch
from
ad1bcdf to
7d905f8
Compare
zannkukai
force-pushed
the
zan-fix-subscriptions
branch
from
7d905f8 to
a44bbc2
Compare
The method to retrieve patrons without valid subscriptions doesn't works as expected. Each day, a new subscription will be added for all patrons linked to patron_type requiring a subscription, even if they have a valid one. Closes rero#1317 Co-Authored-by: Renaud Michotte <[email protected]> Co-Authored-by: lauren-d <[email protected]>
zannkukai
force-pushed
the
zan-fix-subscriptions
branch
from
a44bbc2 to
06f64c7
Compare
lauren-d
approved these changes
Nov 5, 2020
BadrAly
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method to retrieve patrons without valid subscriptions doesn't
works as expected. Each day, a new subscription will be added for all
patrons linked to patron_type requiring a subscription, even if they
have a valid one.
This commit fixes this problem.
Closes #1317
Code review check list