Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue with the patron subscription renewal task #1317

Closed
zannkukai opened this issue Oct 20, 2020 · 0 comments
Closed

issue with the patron subscription renewal task #1317

zannkukai opened this issue Oct 20, 2020 · 0 comments
Assignees
@zannkukai
Labels
bug Breaks something but is not blocking f: user management
Milestone
v0.14.0

Comments

@zannkukai
Copy link
Contributor

zannkukai commented Oct 20, 2020 •
edited
Loading

https://sentrydev.test.rero.ch:9443/organizations/sentry/issues/60332/?referrer=alert_email

During the scheduled task about subscriptions, something was wrong and the error "Add a subscription for patron#4 ... it shouldn't happen !!" appear in the log. This error is due to the funuction "get_patrons_without_subscriptions" ; this function doesn't work as expected (bad ES request) and (often) return all patrons linked to a patron_type requiring subscriptions.

  • server: [ils.test.rero.ch][1]
  • version: 0.13.0

Screenshots
image
@zannkukai zannkukai added triage bug Breaks something but is not blocking labels Oct 20, 2020
@zannkukai zannkukai self-assigned this Oct 20, 2020
@zannkukai zannkukai mentioned this issue Nov 2, 2020
Closed
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Nov 4, 2020
@zannkukai
patrons: fix subscriptions renewal problem.
9c43f29 
The method to retrieve patrons without valid subscriptions doesn't
works as expected. Each day, a new subscription will be added for all
patrons linked to patron_type requiring a subscription, even if they
have a valid one.
This commit fixes this problem.

Closes rero#1317

component: summarize changes in 50 char or less

* Adds your new feature.
* Fixes an existing issue, may closes #issue.
* Improves and existing feature.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Nov 4, 2020
@zannkukai @lauren-d
patrons: fix subscriptions renewal problem.
ad1bcdf 
The method to retrieve patrons without valid subscriptions doesn't
works as expected. Each day, a new subscription will be added for all
patrons linked to patron_type requiring a subscription, even if they
have a valid one.
This commit fixes this problem.

Closes rero#1317

Co-Authored-by: Renaud Michotte <[email protected]>
Co-Authored-by: lauren-d <[email protected]>
@zannkukai zannkukai mentioned this issue Nov 4, 2020
Merged
6 tasks
@iGormilhit iGormilhit added this to the v0.14.0 milestone Nov 5, 2020
@iGormilhit iGormilhit changed the title Sentry: subscription problem issue with the patron subscription renewal task Nov 5, 2020
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Nov 5, 2020
@zannkukai @lauren-d
patrons: fix subscriptions renewal problem.
7d905f8 
The method to retrieve patrons without valid subscriptions doesn't
works as expected. Each day, a new subscription will be added for all
patrons linked to patron_type requiring a subscription, even if they
have a valid one.

Closes rero#1317

Co-Authored-by: Renaud Michotte <[email protected]>
Co-Authored-by: lauren-d <[email protected]>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Nov 5, 2020
@zannkukai @lauren-d
patrons: fix subscriptions renewal problem.
a44bbc2 
The method to retrieve patrons without valid subscriptions doesn't
works as expected. Each day, a new subscription will be added for all
patrons linked to patron_type requiring a subscription, even if they
have a valid one.

Closes rero#1317

Co-Authored-by: Renaud Michotte <[email protected]>
Co-Authored-by: lauren-d <[email protected]>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Nov 5, 2020
@zannkukai @lauren-d
patrons: fix subscriptions renewal problem.
06f64c7 
The method to retrieve patrons without valid subscriptions doesn't
works as expected. Each day, a new subscription will be added for all
patrons linked to patron_type requiring a subscription, even if they
have a valid one.

Closes rero#1317

Co-Authored-by: Renaud Michotte <[email protected]>
Co-Authored-by: lauren-d <[email protected]>
zannkukai added a commit that referenced this issue Nov 5, 2020
@zannkukai @lauren-d
patrons: fix subscriptions renewal problem.
436c825 
The method to retrieve patrons without valid subscriptions doesn't
works as expected. Each day, a new subscription will be added for all
patrons linked to patron_type requiring a subscription, even if they
have a valid one.

Closes #1317

Co-Authored-by: Renaud Michotte <[email protected]>
Co-Authored-by: lauren-d <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
bug Breaks something but is not blocking f: user management
Projects
None yet
Milestone
v0.14.0
Development

No branches or pull requests
2 participants
@iGormilhit @zannkukai