Merged
Conversation
85c46ab to
0451297
Compare
af6cdb9 to
a227481
Compare
ryantm
requested changes
Dec 4, 2023
c2cd393 to
3b22c78
Compare
ryantm
approved these changes
Dec 4, 2023
|
|
||
| initializationOptions = { | ||
| tsserver.path = "${nodepkgs.typescript}/lib/node_modules/typescript/lib"; | ||
| }; |
Collaborator
There was a problem hiding this comment.
cool, verified this general idea works with:
[languages]
[languages.javascript]
pattern = "**/{*.js,*.jsx,*.ts,*.tsx,*.json}"
[languages.javascript.languageServer]
start = "/nix/store/vmd368fmaklyyj232fvnrawqffd4zwq4-nodejs-20.3.1/bin/node /nix/store/gx32fpn4758z67wa4hqc4wcd7mqrvl9z-typescript-language-server-3.3.2/bin/.typescript-language-server-wrapped --stdio"
[languages.javascript.languageServer.initializationOptions.tsserver]
path = "/nix/store/rcsq57nzjj9jypdm6wqycq99smd9slnh-typescript-5.0.4/lib/node_modules/typescript/lib/"
d04fe6f to
79d0bfa
Compare
79d0bfa to
cc0ca7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
we want to move towards always having the latest and greatest instead of pinning to a convenient nixpkgs channel. this is a more moderate attempt at #184 that doesn't attempt to remove all of
nixos-23.05but instead makesnixpkgs-unstablethe default pkgs channel to us in modules.as such, we'll be able to maintain
javaand (more importantly) all python nixmodules until we find a way to build them with unstableWhat changed
nixpkgs-unstableinputpkgstonixpkgs-unstablefor all nixmodulespkgs-23_05tonixos-23.05Test plan
Rollout
Describe any procedures or requirements needed to roll this out safely (or check the box below)