Skip to content

make things unstable again#194

Merged
cdmistman merged 3 commits intomainfrom
cad/make-things-unstable-again
Dec 4, 2023
Merged

make things unstable again#194
cdmistman merged 3 commits intomainfrom
cad/make-things-unstable-again

Conversation

@cdmistman
Copy link
Contributor

Why

we want to move towards always having the latest and greatest instead of pinning to a convenient nixpkgs channel. this is a more moderate attempt at #184 that doesn't attempt to remove all of nixos-23.05 but instead makes nixpkgs-unstable the default pkgs channel to us in modules.

as such, we'll be able to maintain java and (more importantly) all python nixmodules until we find a way to build them with unstable

What changed

  • updated nixpkgs-unstable input
  • set pkgs to nixpkgs-unstable for all nixmodules
  • set pkgs-23_05 to nixos-23.05

Test plan

  • node/python tests pass

Rollout

Describe any procedures or requirements needed to roll this out safely (or check the box below)

  • This is fully backward and forward compatible

@cdmistman cdmistman requested a review from a team as a code owner December 1, 2023 18:15
@cdmistman cdmistman requested review from ryantm and removed request for a team December 1, 2023 18:15
@cdmistman cdmistman force-pushed the cad/make-things-unstable-again branch 2 times, most recently from 85c46ab to 0451297 Compare December 1, 2023 20:16
Copy link
Collaborator

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks good

@cdmistman cdmistman force-pushed the cad/make-things-unstable-again branch 3 times, most recently from af6cdb9 to a227481 Compare December 4, 2023 16:57
@cdmistman cdmistman requested a review from ryantm December 4, 2023 17:33
@cdmistman cdmistman force-pushed the cad/make-things-unstable-again branch from c2cd393 to 3b22c78 Compare December 4, 2023 18:08
@cdmistman cdmistman requested a review from ryantm December 4, 2023 19:11
Copy link
Collaborator

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good


initializationOptions = {
tsserver.path = "${nodepkgs.typescript}/lib/node_modules/typescript/lib";
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, verified this general idea works with:

[languages]

[languages.javascript]
pattern = "**/{*.js,*.jsx,*.ts,*.tsx,*.json}"

[languages.javascript.languageServer]
start = "/nix/store/vmd368fmaklyyj232fvnrawqffd4zwq4-nodejs-20.3.1/bin/node /nix/store/gx32fpn4758z67wa4hqc4wcd7mqrvl9z-typescript-language-server-3.3.2/bin/.typescript-language-server-wrapped --stdio"

[languages.javascript.languageServer.initializationOptions.tsserver]
path = "/nix/store/rcsq57nzjj9jypdm6wqycq99smd9slnh-typescript-5.0.4/lib/node_modules/typescript/lib/"

@cdmistman cdmistman force-pushed the cad/make-things-unstable-again branch from d04fe6f to 79d0bfa Compare December 4, 2023 19:45
@cdmistman cdmistman force-pushed the cad/make-things-unstable-again branch from 79d0bfa to cc0ca7c Compare December 4, 2023 19:48
@cdmistman cdmistman enabled auto-merge December 4, 2023 19:48
@cdmistman cdmistman merged commit fe25c7a into main Dec 4, 2023
@cdmistman cdmistman deleted the cad/make-things-unstable-again branch December 4, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants