Conversation
ryantm
reviewed
Nov 27, 2023
| (import ./python { | ||
| python = pkgs.python38Full; | ||
| pypkgs = pkgs.python38Packages; | ||
| }) |
Collaborator
There was a problem hiding this comment.
Why are we getting rid of python 3.8?
Collaborator
There was a problem hiding this comment.
Oh, I see
removed the python 3.8 nixmodule from the current modules list due to a version incompatibility with sphinx (which i guess is somewhere in the dep tree)
What's the error?
Contributor
Author
There was a problem hiding this comment.
something like sphinx-x.x.x is not a valid interpreter for python 3.8?
Contributor
Author
There was a problem hiding this comment.
it was an error printed by nix (not printed from within a drv) so i think this is just an incompatibility with the latest unstable
75b72fb to
b382abc
Compare
ryantm
approved these changes
Nov 27, 2023
02fc046 to
b9e490e
Compare
b9e490e to
8e25386
Compare
This was referenced Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
it's annoying having multiple nix channels that affect some modules but not others. also it's a lot easier to keep things up-to-date and consistent when we're only using 1 channel. also 23.05 is almost deprecated, and our choices were to either:
What changed
nixos-23.05channel inputnixpkgs-unstableinsteadsphinx(which i guess is somewhere in the dep tree)Test plan
Rollout
Describe any procedures or requirements needed to roll this out safely (or check the box below)