WIP: remove ConnectionControllerClient and move behavior account behavior to ConnectionController #5085
Conversation
…onnectWalletConnect from appkit
…ve-connection-controller-client
…aces with request
…ion, networks fixed
…connection-controller-client
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
10 Skipped Deployments
|
…ve-connection-controller-client
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…ve-connection-controller-client
…ve-connection-controller-client
…ve-connection-controller-client
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…own-com/appkit into chore/remove-conn-controller-2
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
tomiir
changed the base branch from
chore/remove-network-controller-client
to
feat/refactor-chain-adapter-blueprint
Description
Overview
This PR implements a significant architectural refactoring that moves account-related logic from AppKitBaseClient to ConnectionController and completely removes the connectionControllerClient abstraction layer. This change aligns with the AppKit stability improvements initiative and moves us closer to atomic state management.
🎯 Motivation
As outlined in the AppKit Refactor POC Findings & Recommendations, the current architecture has several issues:
Circular Dependencies: Controllers have circular deps through client abstractions
Tangled State: Multiple cross-controller dependencies make atomic updates impossible
Blurry Boundaries: State responsibilities are unclear between controllers
Proxy Pattern Anti-pattern: connectionControllerClient acts as unnecessary middleware
🔄 Changes Made
✅ Removed connectionControllerClient Completely
views → controllers → adapters(instead of views → controllers → client → adapters)🏗️ Moved Account Logic to ConnectionController
The following methods were moved from AppKitBaseClient to ConnectionController:
Connection Management Methods:
Account Operations:
Provider execution
Utility Methods:
Updated Adapter Integration
Adapters now call ConnectionController methods directly instead of through client
Type of change
Associated Issues
Closes APKT-3837
Checklist
Note
Eliminates ConnectionControllerClient and moves account/connection and RPC ops into ConnectionController, refactoring adapters/UI/tests to call controllers directly.
ConnectionControllerClient; shift connection, account sync, identity, balance, unit conversion, ENS, install checks, and RPC ops (request,signMessage,sendTransaction,estimateGas,writeContract) intoConnectionController.views → controllers → adapters; drop client indirection fromAppKitBaseClientandAppKit.AdapterControllernow stores adapters by namespace;ChainController.initializeno longer accepts client; add helpers for approved networks and CAIP network lookup.ProviderController; usenetworksinstead ofgetCaipNetworks(); tighten error messages; minor WalletConnect wiring.networks; adjustsignMessage.BalanceUtilusesConnectionController.requestand ERC-7811 paths;BlockchainApiController.fetchIdentitysimplified and safe.SmartSessionsControllerusesConnectionController.requestfor permissions.SendController/SwapControllerinvokeConnectionController.updateBalanceandsendTransaction.ConnectionController.connectWalletConnect,disconnect, anddisconnectConnectordirectly; update multi-wallet flows.Written by Cursor Bugbot for commit 522553f. This will update automatically on new commits. Configure here.