fix: avoid throwing CONNECT_ERROR when connection request is rejected
#4992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d4cd6d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
10 Skipped Deployments
|
magiziz
changed the title
CONNECT_ERROR when connection request is rejectedCONNECT_ERROR when connection request is rejected
magiziz
changed the title
CONNECT_ERROR when connection request is rejectedCONNECT_ERROR when connection request is rejected
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where CONNECT_ERROR events were incorrectly logged when users rejected connection requests. It introduces a new USER_REJECTED event type to properly distinguish user rejections from actual connection errors.
- Introduces new error handling utilities and
UserRejectedRequestErrorclass in the common package - Updates multiple connection flows to detect user rejection errors and emit
USER_REJECTEDevents instead ofCONNECT_ERROR - Adds comprehensive test coverage for the new error detection utilities
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/common/src/utils/ErrorUtil.ts | New error utility with user rejection detection and error classes |
| packages/common/tests/ErrorUtil.test.ts | Test coverage for new error utilities |
| packages/controllers/src/utils/withErrorBoundary.ts | Enhanced AppKitError class to track original error names |
| packages/controllers/src/utils/TypeUtil.ts | Added USER_REJECTED event type definition |
| packages/scaffold-ui/src/views/w3m-connecting-wc-view/index.ts | Updated error handling to emit USER_REJECTED for user rejections |
| packages/scaffold-ui/src/views/w3m-connecting-external-view/index.ts | Updated error handling to emit USER_REJECTED for user rejections |
| packages/scaffold-ui/src/partials/w3m-connecting-wc-browser/index.ts | Updated error handling to emit USER_REJECTED for user rejections |
| packages/appkit/src/utils/HelpersUtil.ts | Added WalletConnect specific user rejection error detection |
| packages/appkit/src/adapters/ChainAdapterBlueprint.ts | Enhanced connectWalletConnect with user rejection handling |
| packages/adapters/wagmi/src/client.ts | Updated connect methods to throw UserRejectedRequestError for user rejections |
| packages/adapters/solana/src/providers/WalletStandardProvider.ts | Updated connect to throw UserRejectedRequestError |
| packages/adapters/solana/src/providers/CoinbaseWalletProvider.ts | Updated connect to throw UserRejectedRequestError |
| packages/adapters/ethers5/src/client.ts | Wrapped connect method with user rejection error handling |
| packages/adapters/ethers/src/client.ts | Wrapped connect method with user rejection error handling |
| packages/adapters/bitcoin/src/adapter.ts | Updated connect to throw UserRejectedRequestError |
| .changeset/tall-sites-exist.md | Changeset documenting the fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/scaffold-ui/src/partials/w3m-connecting-wc-browser/index.ts
Outdated
Show resolved
Hide resolved
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
enesozturk
reviewed
Sep 10, 2025
enesozturk
reviewed
Sep 10, 2025
tomiir
reviewed
Sep 10, 2025
enesozturk
reviewed
Sep 10, 2025
tomiir
approved these changes
Sep 11, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue where upon user connection rejection a
CONNECT_ERRORevent was logged. It now logs a new new event error calledUSER_REJECTEDType of change
Associated Issues
For Linear issues: Closes APKT-3748
Checklist