Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bitcoin logo on namespace switching view #4055

Merged
merged 5 commits into from
Mar 20, 2025

Conversation

enesozturk
Copy link
Contributor

@enesozturk enesozturk commented Mar 20, 2025

Description

Adds Bitcoin logo to wui-visual component so it's visible on w3m-switch-active-chain-view as expected.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Mar 20, 2025

🦋 Changeset detected

Latest commit: 8087ecb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@reown/appkit-scaffold-ui Patch
@reown/appkit-ui Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-common Patch
@reown/appkit-controllers Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 11:25am
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 11:25am
12 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-ep ⬜️ Ignored (Inspect) Mar 20, 2025 11:25am
appkit-basic-ep-example ⬜️ Ignored (Inspect) Mar 20, 2025 11:25am
appkit-basic-example ⬜️ Ignored (Inspect) Mar 20, 2025 11:25am
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Mar 20, 2025 11:25am
appkit-basic-up-example ⬜️ Ignored (Inspect) Mar 20, 2025 11:25am
appkit-ethers5-bera ⬜️ Ignored (Inspect) Mar 20, 2025 11:25am
appkit-nansen-demo ⬜️ Ignored (Inspect) Mar 20, 2025 11:25am
appkit-vue-solana ⬜️ Ignored (Inspect) Mar 20, 2025 11:25am
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Mar 20, 2025 11:25am
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Mar 20, 2025 11:25am
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) Mar 20, 2025 11:25am
vue-wagmi-example ⬜️ Ignored (Inspect) Mar 20, 2025 11:25am

@enesozturk enesozturk requested review from tomiir and magiziz March 20, 2025 11:18
Copy link
Contributor

Warnings
⚠️ File packages/scaffold-ui/src/views/w3m-switch-active-chain-view/index.ts contains a KEY or SECRET

Generated by 🚫 dangerJS against 8087ecb

Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 75% 24494 / 32658
🔵 Statements 75% 24494 / 32658
🔵 Functions 66.11% 2064 / 3122
🔵 Branches 82.16% 4584 / 5579
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/scaffold-ui/src/views/w3m-switch-active-chain-view/index.ts 66.03% 60% 42.85% 66.03% 41-42, 48, 51-52, 84, 89-103
packages/ui/src/assets/visual/bitcoin.ts 100% 100% 100% 100%
packages/ui/src/components/wui-visual/index.ts 100% 100% 100% 100%
packages/ui/src/utils/TypeUtil.ts 100% 100% 100% 100%
Generated in workflow #10375 for commit 8087ecb by the Vitest Coverage Report Action

@enesozturk enesozturk merged commit 4f79747 into main Mar 20, 2025
31 checks passed
@enesozturk enesozturk deleted the chore/bitcoin-logo-on-namespace-switching-view branch March 20, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants