feat(web-wallet): disable button while loading #4052
Merged
+122
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 67da85c The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
12 Skipped Deployments
|
There was a problem hiding this comment.
Pull Request Overview
This PR improves the web wallet UX by disabling the "Open" button while the wallet connection is being established. Key changes include adding tests to verify button states, introducing an isLoading state in the wallet component, and integrating this state into the widget’s button disabled logic.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/scaffold-ui/test/partials/w3m-connecting-wc-web.test.ts | Added tests to verify that the "Open" button is enabled when a URI is available and disabled otherwise. |
| packages/scaffold-ui/src/partials/w3m-connecting-wc-web/index.ts | Introduced the isLoading state and update mechanism for controlling the button's clickable state. |
| packages/scaffold-ui/src/utils/w3m-connecting-widget/index.ts | Updated the button's disabled attribute logic to consider the new isLoading state. |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
enesozturk
reviewed
Mar 20, 2025
| @@ -0,0 +1,5 @@ | |||
| --- | |||
There was a problem hiding this comment.
We need to select all packages while creating changeset 🙏🏽
enesozturk
reviewed
Mar 20, 2025
| '@reown/appkit-scaffold-ui': patch | ||
| --- | ||
|
|
||
| disable `open` button until connection established |
There was a problem hiding this comment.
We generally follow a practice where explanations start with capital letters unlike the commits for changeset summary
enesozturk
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Web wallets can only be opened once a connection to WalletConnect has been established. Currently the UX is confusing as the button can be clicked whilst loading with no effect. This change disables the button until it is actually clickable.
Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
web-loading.mp4
Checklist