Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update bitcoin image ids #4049

Merged

Conversation

enesozturk
Copy link
Contributor

@enesozturk enesozturk commented Mar 19, 2025

Description

Updates Bitcoin image ids

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

linear bot commented Mar 19, 2025

Copy link

changeset-bot bot commented Mar 19, 2025

🦋 Changeset detected

Latest commit: c0a2636

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@reown/appkit-controllers Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 7:14am
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 7:14am
12 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-ep ⬜️ Ignored (Inspect) Mar 20, 2025 7:14am
appkit-basic-ep-example ⬜️ Ignored (Inspect) Mar 20, 2025 7:14am
appkit-basic-example ⬜️ Ignored (Inspect) Mar 20, 2025 7:14am
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Mar 20, 2025 7:14am
appkit-basic-up-example ⬜️ Ignored (Inspect) Mar 20, 2025 7:14am
appkit-ethers5-bera ⬜️ Ignored (Inspect) Mar 20, 2025 7:14am
appkit-nansen-demo ⬜️ Ignored (Inspect) Mar 20, 2025 7:14am
appkit-vue-solana ⬜️ Ignored (Inspect) Mar 20, 2025 7:14am
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Mar 20, 2025 7:14am
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Visit Preview Mar 20, 2025 7:14am
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) Mar 20, 2025 7:14am
vue-wagmi-example ⬜️ Ignored (Inspect) Mar 20, 2025 7:14am

Copy link
Contributor

github-actions bot commented Mar 19, 2025

Warnings
⚠️ File packages/controllers/src/controllers/ConnectorController.ts contains a KEY or SECRET

Generated by 🚫 dangerJS against c0a2636

Copy link
Contributor

github-actions bot commented Mar 19, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 74.82% 24449 / 32675
🔵 Statements 74.82% 24449 / 32675
🔵 Functions 66% 2058 / 3118
🔵 Branches 82.18% 4581 / 5574
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit-utils/src/PresetsUtil.ts 100% 100% 100% 100%
packages/controllers/src/controllers/ConnectorController.ts 85.36% 96.8% 71.42% 85.36% 50-52, 140-141, 156-157, 167-175, 225, 233-253, 273-274, 337
packages/controllers/src/utils/AssetUtil.ts 90.36% 95.45% 93.33% 90.36% 34-35, 49, 54, 98-99, 117-118
Generated in workflow #10361 for commit c0a2636 by the Vitest Coverage Report Action

@enesozturk enesozturk requested review from tomiir and magiziz March 19, 2025 12:24
Copy link
Contributor

@magiziz magiziz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add changeset ?

Copy link
Collaborator

@tomiir tomiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pr description + changeset plz

@enesozturk enesozturk force-pushed the enes/apkt-2438-bitcoin-logo-is-missing-from-chain-selector branch from d8db691 to c0a2636 Compare March 20, 2025 07:08
@enesozturk enesozturk merged commit c7994ea into main Mar 20, 2025
31 checks passed
@enesozturk enesozturk deleted the enes/apkt-2438-bitcoin-logo-is-missing-from-chain-selector branch March 20, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants