Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove intermediate select screen account on auth connector #2827

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

tomiir
Copy link
Collaborator

@tomiir tomiir commented Sep 9, 2024

Description

  • Removes intermediate select account screen on auth connector multi-address

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections

Copy link

vercel bot commented Sep 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Sep 19, 2024 9:01pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Sep 19, 2024 9:01pm

Copy link
Contributor

github-actions bot commented Sep 9, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 242.9% 4151 / 10400
🔵 Statements 242.9% 4151 / 10400
🔵 Functions 265.11% 320 / 803
🔵 Branches 309.06% 568 / 1042
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/core/src/controllers/RouterController.ts 57.83% 100% 62.5% 57.83% 112-113, 120, 122-124, 126, 128-130, 132-134, 141-142, 144, 146-147, 149-157, 196-203
Generated in workflow #6182

Copy link
Contributor

github-actions bot commented Sep 9, 2024

♻️ Vite-Size ♻️

Size Difference

Size (kb) Gzip (kb)
Total Diff. 0 0

Current Size

Name Size (kb) Gzip (kb)
assets/index-CueFzxuG.js 1865.21 532.825
assets/index.js 9.63 3.159
assets/index2.js 11.572 3.199
assets/w3m-modal.js 7.371 2.601
assets/noble-curves.js 31.941 12.778
assets/2.21.4_bufferutil.js 2.789 1.327
assets/index3.js 102.251 29.116
assets/index4.js 304.393 87.286
assets/hooks.module.js 74.443 25.59
index.html 0.329 0.235
Total Size 2409.929 698.116

Base Size

Name Size (kb) Gzip (kb)
assets/index-CueFzxuG.js 1865.21 532.825
assets/index.js 9.63 3.159
assets/index2.js 11.572 3.199
assets/w3m-modal.js 7.371 2.601
assets/noble-curves.js 31.941 12.778
assets/2.21.4_bufferutil.js 2.789 1.327
assets/index3.js 102.251 29.116
assets/index4.js 304.393 87.286
assets/hooks.module.js 74.443 25.59
index.html 0.329 0.235
Total Size 2409.929 698.116

Copy link

changeset-bot bot commented Sep 19, 2024

🦋 Changeset detected

Latest commit: 221c628

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-utils Patch
@reown/appkit-scaffold-ui Patch
@apps/laboratory Patch
@reown/appkit Patch
@reown/appkit-common Patch
@reown/appkit-wallet Patch
@reown/appkit-core Patch
@apps/demo Patch
@apps/gallery Patch
@examples/html-ethers Patch
@examples/html-ethers5 Patch
@examples/html-wagmi Patch
@examples/next-ethers Patch
@examples/next-wagmi Patch
@examples/react-ethers Patch
@examples/react-ethers5 Patch
@examples/react-solana Patch
@examples/react-wagmi Patch
@examples/vue-ethers5 Patch
@examples/vue-solana Patch
@examples/vue-wagmi Patch
@reown/appkit-adapter-polkadot Patch
@reown/appkit-cdn Patch
@reown/appkit-ethers Patch
@reown/appkit-ethers5 Patch
@reown/appkit-polyfills Patch
@reown/appkit-siwe Patch
@reown/appkit-solana Patch
@reown/appkit-ui Patch
@reown/appkit-wagmi Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants