Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(manager/helm-values): Add support for bumpVersion #26441

Merged
merged 16 commits into from
Jan 17, 2024
Merged

feat(manager/helm-values): Add support for bumpVersion #26441

merged 16 commits into from
Jan 17, 2024

Conversation

kvanzuijlen
Copy link
Contributor

@kvanzuijlen kvanzuijlen commented Dec 27, 2023 •
edited
Loading

Changes

Adds support for bumpVersion to the helm-values manager.

Context

Closes #4728, closes #8231

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@kvanzuijlen kvanzuijlen force-pushed the helm-values-bumpversion-support branch from 4692efe to 869fd72 Compare December 27, 2023 22:48
@kvanzuijlen kvanzuijlen force-pushed the helm-values-bumpversion-support branch from 869fd72 to 2a01fce Compare December 27, 2023 22:48
@kvanzuijlen kvanzuijlen force-pushed the helm-values-bumpversion-support branch from d8104e7 to 58ab838 Compare December 27, 2023 23:17
@kvanzuijlen kvanzuijlen marked this pull request as ready for review December 27, 2023 23:19
kvanzuijlen
kvanzuijlen commented Dec 27, 2023
View reviewed changes
Copy link
Contributor Author

@kvanzuijlen kvanzuijlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rarkins I could reuse most parts from #8240. I was able to reproduce the behavior that caused it to be reverted.

Do you want to include helm-requirements in the same PR or should that (optionally) be added in a separate PR? I don't think it's really necessary, as helmv3 has long been the standard already and as far as I understand, helm-requirements is for Chart dependencies in helmv2 (correct?).

lib/workers/repository/update/branch/get-updated.ts Outdated Show resolved Hide resolved
@kvanzuijlen kvanzuijlen marked this pull request as draft December 27, 2023 23:27
@kvanzuijlen
fix: Fixed tests
88700f1 
Signed-off-by: kvanzuijlen <[email protected]>
@kvanzuijlen kvanzuijlen marked this pull request as ready for review December 28, 2023 00:28
@kvanzuijlen kvanzuijlen changed the title feat(helm-values): Add support for bumpVersion feat(manager/helm-values): Add support for bumpVersion Dec 28, 2023
viceice
viceice reviewed Dec 28, 2023
View reviewed changes
lib/modules/manager/helm-values/update.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/helm-values/update.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/helm-values/util.ts Outdated Show resolved Hide resolved
@rarkins
Copy link
Collaborator

rarkins commented Dec 28, 2023

Different managers can be done separately

@kvanzuijlen
Copy link
Contributor Author

Thanks for taking the time to review my PR @viceice. I hope my changes are correct. Let me know if I need to change anything else!

@kvanzuijlen kvanzuijlen mentioned this pull request Jan 3, 2024
Merged
4 tasks
viceice
viceice reviewed Jan 3, 2024
View reviewed changes
lib/modules/manager/helm-values/update.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/helm-values/types.ts Outdated Show resolved Hide resolved
lib/modules/manager/helm-values/types.ts Outdated Show resolved Hide resolved
@kvanzuijlen
Copy link
Contributor Author

kvanzuijlen commented Jan 3, 2024 •
edited
Loading

Thanks for all your patience @viceice. I made the requested changes.

@kvanzuijlen kvanzuijlen mentioned this pull request Jan 7, 2024
Merged
6 tasks
viceice
viceice requested changes Jan 8, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocked by refactor PR

@viceice viceice added this pull request to the merge queue Jan 17, 2024
Merged via the queue into renovatebot:main with commit 3f0eec4 Jan 17, 2024
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.138.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@oscrx oscrx mentioned this pull request Jan 17, 2024
Closed
@rarkins rarkins mentioned this pull request Jan 20, 2024
Merged
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 22, 2024
@kvanzuijlen @zT-1337
feat(manager/helm-values): Add support for bumpVersion (renovatebot#2…
8cfead0 
…6441)

Signed-off-by: kvanzuijlen <[email protected]>
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
@kvanzuijlen @zT-1337
feat(manager/helm-values): Add support for bumpVersion (renovatebot#2…
24cd593 
…6441)

Signed-off-by: kvanzuijlen <[email protected]>
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
@kvanzuijlen @zT-1337
feat(manager/helm-values): Add support for bumpVersion (renovatebot#2…
f2b7ba6 
…6441)

Signed-off-by: kvanzuijlen <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@secustor secustor Awaiting requested review from secustor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm dependencies should optionally bump chart.yaml Support for bumpVersion when updating helm-values
5 participants
@kvanzuijlen @rarkins @renovate-release @viceice @secustor