-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manager/helm-values): Add support for bumpVersion #26441
feat(manager/helm-values): Add support for bumpVersion #26441
Conversation
4692efe
to
869fd72
Compare
Signed-off-by: kvanzuijlen <[email protected]>
Signed-off-by: kvanzuijlen <[email protected]>
869fd72
to
2a01fce
Compare
Signed-off-by: kvanzuijlen <[email protected]>
Signed-off-by: kvanzuijlen <[email protected]>
d8104e7
to
58ab838
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rarkins I could reuse most parts from #8240. I was able to reproduce the behavior that caused it to be reverted.
Do you want to include helm-requirements in the same PR or should that (optionally) be added in a separate PR? I don't think it's really necessary, as helmv3 has long been the standard already and as far as I understand, helm-requirements is for Chart dependencies in helmv2 (correct?).
Signed-off-by: kvanzuijlen <[email protected]>
Different managers can be done separately |
Signed-off-by: kvanzuijlen <[email protected]>
Thanks for taking the time to review my PR @viceice. I hope my changes are correct. Let me know if I need to change anything else! |
Signed-off-by: kvanzuijlen <[email protected]>
… into helm-values-bumpversion-support
Thanks for all your patience @viceice. I made the requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocked by refactor PR
🎉 This PR is included in version 37.138.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
…6441) Signed-off-by: kvanzuijlen <[email protected]>
…6441) Signed-off-by: kvanzuijlen <[email protected]>
…6441) Signed-off-by: kvanzuijlen <[email protected]>
Changes
Adds support for
bumpVersion
to the helm-values manager.Context
Closes #4728, closes #8231
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: