-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm dependencies should optionally bump chart.yaml #4728
Comments
Yeah, this should be possible. We already have this functionality for bumping the version in |
Hi @rarkins I'd love to see this feature included. Can I help with the requirements or testing at all? Functionality like https://docs.renovatebot.com/configuration-options/#bumpversion would be great. To implement this, the |
@travisgroth which of our managers would this be applicable to? e.g. It will be a little bit tricky because npm's updating approach is quite unique compared to other managers and so therefore you can't simply copy over the way it does I think we'd need to add an optional new function to managers with same or similar signature as this one in npm: renovate/lib/manager/npm/update.ts Lines 7 to 58 in de5de8e
Then we'd need to work out where/how to call it, potentially here:
|
My immediate use case is for
|
I've got an implementation of this going for helmv3 at #7670 :) |
Hi there, The Renovate team needs your help! To fix the problem, we first need to know exactly what's causing the bug. A minimal reproduction help us to pinpoint the exact cause of the bug. To get started, please read our guide on minimal reproductions to understand what is needed. We may close the issue if you have not provided a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment. Good luck, The Renovate team |
I think this has been implemented in #7670 already, no? |
@multani not completely. The chart version isn't bumped by the helm-values manager AFACT. The practical result is that if you bump your image version, the chart metadata isn't updated. Only updates to your chart's dependencies properly bump the chart version. You can see the difference in these two PRs: https://github.com/pomerium/pomerium-helm/pull/232/files (helmv3 manager update) |
@rarkins @HonkingGoose any chance of this getting some attention? |
@travisgroth the issue labeled with |
Hi @rarkins, I am interested in seeing this feature happen for the Is there any way we can help with the "Once there's a minimal reproduction" part? Should a PR made by helm right now be sufficient, or were you thinking about something else? Thanks! |
Hi @roobre, a PR would be most welcome. You're also welcome to jump straight to the PR if you're confident in it. Normally we recommend for contributor's sakes to create a reproduction and discuss how it would work within the issue first, just to reduce the chance of misunderstandings. |
Hey @rarkins, In this case we might jump straight to the PR as you suggest because I think the base functionality is pretty much what the title of this issue says. Of course we can discuss any detail in the PR :) I'll add this to the team's backlog and see if we can get to work on it soon! |
Hey @rarkins, I've created a repro repo here: https://github.com/roobre/renovate-helm-version
|
is helm values manager for the EOL helm version V2? |
@viceice As far as I can tell |
No,
|
is there additional testing required to move this forward after @roobre's comment, #4728 (comment) ? |
This issue has label status:ready which means PRs are welcome |
@rarkins I'd be willing to take a crack at this, as it would also help out big time for what I'm working on with jenkinsci/helm-charts#975. I hope/think I can come up with something before the end of the year. I'll keep you posted! |
This comment has been minimized.
This comment has been minimized.
Apparently reverted in #26758 |
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
Hi there, Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible. Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues. Please follow these steps:
Good luck, The Renovate team |
Hi, could someone who's interested in this feature create a reproduction which follows our above guidelines? e.g. including a readme explaining observed vs expected behavior. I think the best way to do this would be to:
|
What would you like Renovate to be able to do?
It is great that renovate supports helm dependency management now. But, it would be great if renovate can optionally bump the chart version in chart.yaml in the PR as the new chart needs to be published as a new vesion.
Describe the solution you'd like
Renovate should (optionally ) bump the chart version in Chart.yaml when raising a PR to bump requirements.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Currently one way is to manually edit it so that we can publish a new version of chart.
Additional context
NA
The text was updated successfully, but these errors were encountered: