Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed import issues, and got mllint to return near-perfect score #20

Merged
merged 8 commits into from
Jun 21, 2023
Merged

Fixed import issues, and got mllint to return near-perfect score #20

merged 8 commits into from
Jun 21, 2023

Conversation

JvanderSaag
Copy link
Contributor

What changes does this PR introduce?

  • Module imports are now working
  • DVC pipeline has been updated to work with mllint
  • mllint now returns near-perfect score (needs more tests coverage)
  • poetry dependencies have been updated, now must use 3.8.* to avoid 3.11 wrapt import conflict.
  • Reports are now no longer pushed to github, will regenerate on poetry run dvc repro
  • Readme updated with relevant instructions

TODO

  • Further upgrade tests for more coverage -> perfect mllint score

@JvanderSaag JvanderSaag requested a review from a team as a code owner June 21, 2023 12:39
@alemoraru alemoraru merged commit cfe068b into main Jun 21, 2023
@alemoraru alemoraru deleted the pytest branch June 21, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alemoraru alemoraru alemoraru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JvanderSaag @alemoraru