Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize dependencies found through route module graphs #9921

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented Aug 29, 2024

Fixes #8917 #9798
Might fix #8803 #8876

See changeset for description

Copy link

changeset-bot bot commented Aug 29, 2024

🦋 Changeset detected

Latest commit: 10f0715

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -132,7 +132,7 @@
"vite": "5.1.3",
"vite-tsconfig-paths": "^4.2.2",
"wait-on": "^7.0.1",
"wrangler": "^3.24.0"
"wrangler": "^3.72.3"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR, our CI integration suite was failing due to outdated wrangler version, so batched that fix in here.

@pcattori pcattori merged commit 8152c40 into dev Aug 29, 2024
9 checks passed
@pcattori pcattori deleted the pedro/optimize-deps branch August 29, 2024 21:29
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Aug 29, 2024
// https://vitejs.dev/config/dep-optimization-options
let isOptimizeDeps =
viteCommand === "serve" &&
(options as { scan?: boolean })?.scan === true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, why is this not on the type? 🤔

@@ -1075,6 +1075,9 @@ export const remixVitePlugin: RemixVitePlugin = (remixUserConfig = {}) => {
: undefined,
},
optimizeDeps: {
entries: Object.values(ctx.remixConfig.routes).map((route) =>
Copy link
Member

@markdalgleish markdalgleish Sep 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the docs for optimizeDeps.entries:

If build.rollupOptions.input is specified, Vite will crawl those entry points instead

I wonder if the root cause is that we're only applying the Rollup build options when the build command is running:

...(viteCommand === "build"
? {
build: {
cssMinify: viteUserConfig.build?.cssMinify ?? true,
...(!viteConfigEnv.isSsrBuild
? {
manifest: true,
outDir: getClientBuildDirectory(ctx.remixConfig),
rollupOptions: {

Copy link
Contributor

github-actions bot commented Sep 5, 2024

🤖 Hello there,

We just published version 2.12.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

github-actions bot commented Sep 9, 2024

🤖 Hello there,

We just published version 2.12.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants