-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize dependencies found through route module graphs #9921
Conversation
🦋 Changeset detectedLatest commit: 10f0715 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -132,7 +132,7 @@ | |||
"vite": "5.1.3", | |||
"vite-tsconfig-paths": "^4.2.2", | |||
"wait-on": "^7.0.1", | |||
"wrangler": "^3.24.0" | |||
"wrangler": "^3.72.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR, our CI integration suite was failing due to outdated wrangler
version, so batched that fix in here.
1b3d1db
to
10f0715
Compare
// https://vitejs.dev/config/dep-optimization-options | ||
let isOptimizeDeps = | ||
viteCommand === "serve" && | ||
(options as { scan?: boolean })?.scan === true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, why is this not on the type? 🤔
@@ -1075,6 +1075,9 @@ export const remixVitePlugin: RemixVitePlugin = (remixUserConfig = {}) => { | |||
: undefined, | |||
}, | |||
optimizeDeps: { | |||
entries: Object.values(ctx.remixConfig.routes).map((route) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the docs for optimizeDeps.entries:
If build.rollupOptions.input is specified, Vite will crawl those entry points instead
I wonder if the root cause is that we're only applying the Rollup build options when the build
command is running:
remix/packages/remix-dev/vite/plugin.ts
Lines 1126 to 1134 in 8f38118
...(viteCommand === "build" | |
? { | |
build: { | |
cssMinify: viteUserConfig.build?.cssMinify ?? true, | |
...(!viteConfigEnv.isSsrBuild | |
? { | |
manifest: true, | |
outDir: getClientBuildDirectory(ctx.remixConfig), | |
rollupOptions: { |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
Fixes #8917 #9798
Might fix #8803 #8876
See changeset for description