Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old Vite template #9126

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Conversation

markdalgleish
Copy link
Member

The vite template is a duplicate of the newly updated remix template. It was only left here until create-vite updated to point to the default template. Now that Vite 5.2 has shipped including this PR — vitejs/vite#16203 — the vite template is no longer needed.

Copy link

changeset-bot bot commented Mar 24, 2024

⚠️ No Changeset found

Latest commit: 6f48a39

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@markdalgleish markdalgleish merged commit 48ec068 into main Mar 24, 2024
2 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/remove-vite-template branch March 24, 2024 23:49
@kiliman
Copy link
Collaborator

kiliman commented Mar 25, 2024

Removing the Vite template breaks https://remix.new as it tries to fork that template. I'm not sure who's responsible for that URL.

image

@hceresetti
Copy link

Removing the Vite template breaks https://remix.new as it tries to fork that template. I'm not sure who's responsible for that URL.

image

I discovered this situation almost right now.

I thought to open an issue reporting such occasion.

But then, I found this PR and focused to read it.

Thank you for noticing it and leave me conscious of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants