Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass resolved viteConfig to buildEnd hook #8885

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

markdalgleish
Copy link
Member

@markdalgleish markdalgleish commented Feb 26, 2024

This lets presets have access to the resolved Vite config after the build is complete.

This is primarily being driven by the in-progress Vercel preset so that they know which static assets can be cached indefinitely, especially now that we've fixed support for custom asset directories in #8843.

It's worth calling out that presets only get access to the Vite config once the build is complete, so this doesn't open a back door for them to modify the config.

cc @TooTallNate.

Copy link

changeset-bot bot commented Feb 26, 2024

🦋 Changeset detected

Latest commit: bc615c7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Minor
create-remix Minor
remix Minor
@remix-run/architect Minor
@remix-run/cloudflare Minor
@remix-run/cloudflare-pages Minor
@remix-run/cloudflare-workers Minor
@remix-run/css-bundle Minor
@remix-run/deno Minor
@remix-run/eslint-config Minor
@remix-run/express Minor
@remix-run/node Minor
@remix-run/react Minor
@remix-run/serve Minor
@remix-run/server-runtime Minor
@remix-run/testing Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish markdalgleish merged commit 01cac7b into dev Feb 26, 2024
9 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/buildend-viteconfig branch February 26, 2024 21:01
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Feb 26, 2024
TooTallNate pushed a commit to vercel/remix that referenced this pull request Feb 26, 2024
Copy link
Contributor

🤖 Hello there,

We just published version 2.8.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.8.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant