Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vite: reduce network calls for route modules during HMR #8591

Merged
merged 2 commits into from
Jan 25, 2024
Merged

vite: reduce network calls for route modules during HMR #8591

merged 2 commits into from
Jan 25, 2024

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented Jan 24, 2024 •
edited
Loading

BEFORE

Screenshot 2024-01-24 at 12 01 46 PM

👆 The ?import&t= request is redundant. Same module as the ?t= request (both are 8.1kb)

AFTER

Screenshot 2024-01-24 at 12 02 47 PM

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 7a255d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori pcattori marked this pull request as draft January 24, 2024 16:30
@pcattori pcattori force-pushed the pedro/optimize-hmr branch 2 times, most recently from 54533b0 to b9632ca Compare January 24, 2024 16:55
@pcattori pcattori changed the title vite: piggyback on vite's imported route modules for hmr vite: reduce network calls for route modules during HMR Jan 24, 2024
@pcattori
vite: reduce network calls for route modules during HMR
9d488bb 
by piggybacking on Vite's HMR runtime that already receives the updated
module
@pcattori
pr feedback
7a255d6
@pcattori pcattori marked this pull request as ready for review January 25, 2024 17:04
@pcattori pcattori merged commit 2f46b31 into dev Jan 25, 2024
9 checks passed
@pcattori pcattori deleted the pedro/optimize-hmr branch January 25, 2024 17:04
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jan 25, 2024
@github-actions github-actions bot mentioned this pull request Jan 31, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.6.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot mentioned this pull request Feb 1, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024

🤖 Hello there,

We just published version 2.6.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markdalgleish markdalgleish markdalgleish approved these changes

Assignees
No one assigned
Labels
CLA Signed vite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcattori @markdalgleish @brophdawg11