Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): fix errors for non-existent index.html importer #8353

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented Dec 21, 2023

Testing strategy:

Tried it locally with LOCAL_BUILD_DIRECTORY on a simple express + vite app that was having the same error before.

Copy link

changeset-bot bot commented Dec 21, 2023

🦋 Changeset detected

Latest commit: bfa0345

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori pcattori merged commit 66adc8f into release-next Dec 21, 2023
9 checks passed
@pcattori pcattori deleted the pedro/hot-fix-vite-index-html-error branch December 21, 2023 22:24
Copy link
Contributor

🤖 Hello there,

We just published version 2.4.1-pre.3 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.4.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@pcattori pcattori mentioned this pull request Dec 29, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants