fix(remix-dev): fix FutureConfig
type
#7895
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a fix in #7261 to disallow unknown/removed future flags but it turns out that fix only worked when
FutureConfig
was empty - which it was at that time since we were preparing to release v2. Now that we added the first. v3 future flag we found out this isn't the right approach and need to use a conditional type instead.https://www.typescriptlang.org/play?#code/JYOwLgpgTgZghgYwgAgGIFczqhAwgexBmAHNkBvAKAEgA3AZgH0o4ATVCOLHALmQCN8+ADacQlAL6VKoSLEQoAggAdlBIqQqVkO5DEzYIAfj4BtANYQAnvhhoDOdcRIBdZBAAekEKwDOyUxAIWmg3IwoLaz5fMChQVz4gkKgJZD4ABTgoMGA4YQAeDG48QmcAPklpUTBkBFLNAF4tan1ivipqOiYWdk425Fj0CAAaGjoAJkYAdzAACwgEcz5BkZoJUdTfLmBfYgh-FTV6kmkZcGh4JHtip1JxrSkzuUulVVuSe6pdPQdjM0sbHYioZ3m5PN4-AEkqFkOFyJErNFYvEXIlgtBUhksjk8oVfu8Ko9qrVjvcmh1WoZ2mMGMw2BwuFSBlAhqNOrRJjN5otlizVtR1pJkFscrtgPtkId3uNKEA