Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-dev): fix FutureConfig type #7895

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

brophdawg11
Copy link
Contributor

We added a fix in #7261 to disallow unknown/removed future flags but it turns out that fix only worked when FutureConfig was empty - which it was at that time since we were preparing to release v2. Now that we added the first. v3 future flag we found out this isn't the right approach and need to use a conditional type instead.

https://www.typescriptlang.org/play?#code/JYOwLgpgTgZghgYwgAgGIFczqhAwgexBmAHNkBvAKAEgA3AZgH0o4ATVCOLHALmQCN8+ADacQlAL6VKoSLEQoAggAdlBIqQqVkO5DEzYIAfj4BtANYQAnvhhoDOdcRIBdZBAAekEKwDOyUxAIWmg3IwoLaz5fMChQVz4gkKgJZD4ABTgoMGA4YQAeDG48QmcAPklpUTBkBFLNAF4tan1ivipqOiYWdk425Fj0CAAaGjoAJkYAdzAACwgEcz5BkZoJUdTfLmBfYgh-FTV6kmkZcGh4JHtip1JxrSkzuUulVVuSe6pdPQdjM0sbHYioZ3m5PN4-AEkqFkOFyJErNFYvEXIlgtBUhksjk8oVfu8Ko9qrVjvcmh1WoZ2mMGMw2BwuFSBlAhqNOrRJjN5otlizVtR1pJkFscrtgPtkId3uNKEA

Copy link

changeset-bot bot commented Nov 3, 2023

🦋 Changeset detected

Latest commit: 9100b63

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MichaelDeBoey MichaelDeBoey changed the title Fix FutureConfig type fix(remix-dev): fix FutureConfig type Nov 3, 2023
@brophdawg11 brophdawg11 merged commit 22c6f65 into dev Nov 6, 2023
9 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/fix-future-config-type branch November 6, 2023 15:56
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Nov 6, 2023
Copy link
Contributor

🤖 Hello there,

We just published version 2.3.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.3.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants