Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): fix behind-by-one-render bug for meta HMR #7829

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented Oct 30, 2023

and all other non-component Remix exports like links too

Fixes #7787

and all other non-component Remix exports like `links` too

Co-authored-by: Hiroshi Ogawa <[email protected]>
@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2023

🦋 Changeset detected

Latest commit: 3a4d140

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori pcattori linked an issue Oct 30, 2023 that may be closed by this pull request
1 task
@@ -141,16 +143,20 @@ test("Vite custom server HMR & HDR", async ({ page }) => {

// setup: browser state
let hmrStatus = page.locator("#index [data-hmr]");
await expect(page).toHaveTitle("HMR updated title: 0");
await expect(hmrStatus).toHaveText("HMR updated: 0");
let input = page.locator("#index input");
await expect(input).toBeVisible();
await input.type("stateful");

// route: HMR
await edit("app/routes/_index.tsx", (contents) =>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed you added an edit util. I was thinking of writing this too. This is super nice.

@pcattori pcattori merged commit 43027e3 into release-next Oct 31, 2023
9 checks passed
@pcattori pcattori deleted the pedro/fix-vite-meta-hmr branch October 31, 2023 01:56
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.2.0-pre.3 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.2.0-pre.4 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.2.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HMR for meta is behind by one render
2 participants