-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vite): fix behind-by-one-render bug for meta
HMR
#7829
Conversation
and all other non-component Remix exports like `links` too Co-authored-by: Hiroshi Ogawa <[email protected]>
🦋 Changeset detectedLatest commit: 3a4d140 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -141,16 +143,20 @@ test("Vite custom server HMR & HDR", async ({ page }) => { | |||
|
|||
// setup: browser state | |||
let hmrStatus = page.locator("#index [data-hmr]"); | |||
await expect(page).toHaveTitle("HMR updated title: 0"); | |||
await expect(hmrStatus).toHaveText("HMR updated: 0"); | |||
let input = page.locator("#index input"); | |||
await expect(input).toBeVisible(); | |||
await input.type("stateful"); | |||
|
|||
// route: HMR | |||
await edit("app/routes/_index.tsx", (contents) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed you added an edit
util. I was thinking of writing this too. This is super nice.
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
and all other non-component Remix exports like
links
tooFixes #7787