fix(vite): remove server exports from resource routes #7828
Conversation
🦋 Changeset detectedLatest commit: acc17a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pcattori
force-pushed
the
pedro/fix-vite-resource-route-server-code-removal
branch
from
8f2788b
to
68ef921
Compare
|
|
||
| // grep for server-only values in client assets | ||
| let result = shell | ||
| .grep("-l", /SERVER_ONLY_1|SERVER_ONLY_2/, assetFiles) |
There was a problem hiding this comment.
Should this be simplified to target just "SERVER_ONLY" for both exports rather than numbering them? Makes modifying this test less error prone.
| @@ -632,20 +632,6 @@ export const remixVitePlugin: RemixVitePlugin = (options = {}) => { | |||
|
|
|||
| let serverExports = ["loader", "action", "headers"]; | |||
|
|
|||
| let routeExports = await getRouteModuleExports( | |||
There was a problem hiding this comment.
I like that the route transform doesn't need to run this anymore.
pcattori
deleted the
pedro/fix-vite-resource-route-server-code-removal
branch
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
Fixes #7795
Testing Strategy
Added integration cases to
vite buildtest checking that server values get removed from client, and that build succeeds without errors referring to server code.Test was failing before the change, and passes now