Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: using a local *.tgz stack #7649

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Conversation

real34
Copy link
Contributor

@real34 real34 commented Oct 12, 2023

This PR allows to create a Remix application from a *.tgz Remix Stack tarball.

My use case was to directly consume tarballs created by pnpm pack, but only tar.gz extension was supported in Remix.
ℹ️ In pnpm, the tgz extension is also hardcoded and I considered it'd be better to support more tarballs formats in Remix.

  • Docs
  • Tests

Testing Strategy:

  • I duplicated existing test case and fixture for tar.gz tarball
  • before that, I ran a create-remix command by renaming my local archive to tar.gz and it worked as expected

@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2023

🦋 Changeset detected

Latest commit: 9ec284f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11
Copy link
Contributor

Thanks!

@brophdawg11 brophdawg11 merged commit 1f5b740 into remix-run:dev Oct 12, 2023
9 checks passed
@real34 real34 deleted the allow-tgz-stacks branch October 13, 2023 07:13
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.1.0-pre.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.2.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.2.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants