Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FOUC on subsequent client-side navigations to route.lazy routes #7576

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Oct 2, 2023

Fixes a regression from the switch to route.lazy. loadRouteModulesWithBlockingLinks happens on the initial route to a route.lazy route, but then was not included in the subsequent loader/action executions once we remove .lazy.

View with whitespace changes hidden

Closes #7516

@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2023

🦋 Changeset detected

Latest commit: 83dd437

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/react Patch
@remix-run/testing Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 self-assigned this Oct 4, 2023
@brophdawg11 brophdawg11 merged commit 20baca1 into dev Oct 5, 2023
5 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/fix-route-module-css branch October 5, 2023 15:20
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Oct 5, 2023
@brophdawg11 brophdawg11 mentioned this pull request Oct 5, 2023
1 task
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.1.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.1.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants