fix: sourcemap takes into account special chars in output file #7574
Conversation
🦋 Changeset detectedLatest commit: 1eb815b The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -14,7 +14,7 @@ export async function write( | |||
| if ([".js", ".cjs", ".mjs"].some((ext) => file.path.endsWith(ext))) { | |||
| // fix sourceMappingURL to be relative to current path instead of /build | |||
| let filename = file.path.substring(file.path.lastIndexOf(path.sep) + 1); | |||
| let escapedFilename = filename.replace(/\./g, "\\."); | |||
| let escapedFilename = filename.replace(/([.[\]])/g, "\\$1"); | |||
There was a problem hiding this comment.
I like this regex better than the 3-pass replace in #5809, but do we need to also escape the [ in the regex, as suggested in #3768 (comment)?
| let escapedFilename = filename.replace(/([.[\]])/g, "\\$1"); | |
| let escapedFilename = filename.replace(/([.\[\]])/g, "\\$1"); |
There was a problem hiding this comment.
No, it's inside the existing group, so it's not needed.
github-actions
bot
added
the
awaiting release
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
github-actions
bot
removed
the
awaiting release
Closes: #3768
Testing Strategy:
Initialized a new CF Pages template and built Remix into it. Ran the project, connected a debugger, threw an error in a loader and sourcemaps brought me back to the correct line in the source
.tsroute.