Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support bun package manager #7074

Merged
merged 10 commits into from
Aug 16, 2023

Conversation

colinhacks
Copy link
Contributor

@colinhacks colinhacks commented Aug 5, 2023

This adds support for bun to the create-remix package manager detection system. Bun sets the value of npm_config_user_agent when executing a script with bun run/bunx. When a Bun user runs bunx create-remix, they will be prompted to use bun install to install dependencies.

Testing

After building the CLI with yarn build I ran the create-remix script with the npm_config_user_agent set appropriately. It detected the variable and ran bun install as expected.

$ npm_config_user_agent=bun/1.0 node build/node_modules/create-remix/dist/cli.js

 remix   v1.19.2 💿 Let's build a better website...

   dir   Where should we create your new project?
         ./my-remix-app

      ◼  Using basic template See https://remix.run/docs/pages/templates for more
      ✔  Template copied

   git   Initialize a new git repository?
         Yes

  deps   Install dependencies with bun?
         Yes

      ✔  Dependencies installed

      ✔  Git initialized

  done   That's it!

         Enter your project directory using cd ./my-remix-app
         Check out README.md for development and deploy instructions.

         Join the community at https://rmx.as/discord

@changeset-bot
Copy link

changeset-bot bot commented Aug 5, 2023

🦋 Changeset detected

Latest commit: 88c4c2b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
create-remix Minor
@remix-run/dev Minor
remix Minor
@remix-run/architect Minor
@remix-run/cloudflare Minor
@remix-run/cloudflare-pages Minor
@remix-run/cloudflare-workers Minor
@remix-run/css-bundle Minor
@remix-run/deno Minor
@remix-run/eslint-config Minor
@remix-run/express Minor
@remix-run/node Minor
@remix-run/react Minor
@remix-run/serve Minor
@remix-run/server-runtime Minor
@remix-run/testing Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@colinhacks colinhacks marked this pull request as ready for review August 5, 2023 02:36
@MichaelDeBoey MichaelDeBoey changed the title Support bun package manager in create-remix feat: support bun package manager Aug 6, 2023
.changeset/popular-trains-do.md Outdated Show resolved Hide resolved
.changeset/popular-trains-do.md Outdated Show resolved Hide resolved
@colinhacks
Copy link
Contributor Author

colinhacks commented Aug 9, 2023

Thanks Michaël, just committed your suggestions.

FYI I also added bun to the create-remix docs here: ddea794 Let me know if it isn't kosher.

@colinhacks colinhacks changed the title feat: support bun package manager feat: detect bun package manager in create-remix Aug 10, 2023
@MichaelDeBoey MichaelDeBoey changed the title feat: detect bun package manager in create-remix feat: support bun package manager Aug 16, 2023
@markdalgleish markdalgleish merged commit 96b05af into remix-run:dev Aug 16, 2023
9 checks passed
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-96b05af-20230816 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants