Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix-serve): install source-map-support #7039

Conversation

MichaelDeBoey
Copy link
Member

Follow-up of ##7009 & #7010

This should be in a patch release

@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2023

🦋 Changeset detected

Latest commit: 70c7290

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/serve Patch
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11
Copy link
Contributor

Can you provide some context here? Was this there previously and got removed? Or was it never there to begin with? Or is this a "prep for v2" thing? I've not been able to fully follow everything going on in main and dev around globals and sourcemaps.

@MichaelDeBoey
Copy link
Member Author

@brophdawg11 These are the changes @jacob-ebey did on dev, but we should release this as a patch release as well, so the Fly & Remix templates (and Indie stack as well) also already take benefit of them (just like the other Node adapter templates did in #7010)

@brophdawg11
Copy link
Contributor

OK cool. This is fully backwards compatible with v1? If so - let's repoint to release-hotfix and add a changeset to include in 1.19.2

@MichaelDeBoey
Copy link
Member Author

@brophdawg11 It is indeed fully BC as the breaking change is the removal of source-map-support from @remix-run/node

I'll rebase and add a changeset

@MichaelDeBoey MichaelDeBoey force-pushed the install-source-map-support-in-remix-serve branch from 0953022 to d6cfc50 Compare August 3, 2023 15:18
@MichaelDeBoey MichaelDeBoey force-pushed the install-source-map-support-in-remix-serve branch from d6cfc50 to 70c7290 Compare August 3, 2023 15:19
@MichaelDeBoey MichaelDeBoey changed the base branch from main to release-hotfix August 3, 2023 15:19
@MichaelDeBoey
Copy link
Member Author

@brophdawg11 Should be fine now 👍

@brophdawg11 brophdawg11 merged commit 594dff7 into remix-run:release-hotfix Aug 3, 2023
8 of 9 checks passed
@MichaelDeBoey MichaelDeBoey deleted the install-source-map-support-in-remix-serve branch August 3, 2023 15:52
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

🤖 Hello there,

We just published version 1.19.2-pre.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

🤖 Hello there,

We just published version 1.19.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

eastlondoner pushed a commit to eastlondoner/remix that referenced this pull request Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants