Heartbeat: implement in both live-reload servers #6927
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates #6904 to apply the heartbeat to both version of the live-reload server.
Testing Strategy:
Run a remix app in dev mode and load it via a Cloudflare tunnel:
npm run dev & cloudflared tunnel --url http://localhost:57763
Now open the tunnel URL and wait 100 seconds. The socket connection will be closed and the page will reload.