feat(dev): support empty server polyfills #6859
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6665.
This modifies the API for the
serverNodeBuiltinsPolyfill
option so that you can also opt into empty polyfills. This is because our old polyfill setup provided empty polyfills by default forfs
,crypto
,dns
,dgram
,cluster
,repl
andtls
.Note that I've nested the modules config within an object (matching the API of esbuild-plugins-node-modules-polyfill) so that we can add more options in the future without it being a breaking change.