Fix bug with ?_data request on non-matching route #6820
Conversation
🦋 Changeset detectedLatest commit: 0fce002 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| let match = matches!.find((match) => match.route.id == routeId)!; | ||
| response = await build.entry.module.handleDataRequest(response, { | ||
| context: loadContext, | ||
| params: match ? match.params : {}, | ||
| params: matches?.find((m) => m.route.id == routeId)?.params || {}, |
There was a problem hiding this comment.
When handleDataRequest was defined and a request came in like /not-a-route?_data=routes/not-a-route we got a valid 404 from the static handler but then errored out here trying to get the params when no matches exist.
github-actions
bot
added
the
awaiting release
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
github-actions
bot
removed
the
awaiting release
Closes #5738