Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dev): add serverNodeBuiltinsPolyfill option #6814

Merged
merged 10 commits into from
Jul 13, 2023
Merged

feat(dev): add serverNodeBuiltinsPolyfill option #6814

merged 10 commits into from
Jul 13, 2023

Conversation

markdalgleish
Copy link
Member

@markdalgleish markdalgleish commented Jul 12, 2023 •
edited
Loading

Fixes #6715.

This PR replaces and builds on top of #6547, making the following changes:

  • Unimplemented polyfills are excluded by default since it's pointless to polyfill them if the server can't even run this code.
  • A list of polyfills can be provided if consumers want a very specific subset of polyfills.

@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 84281d9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/dev Minor
create-remix Minor
remix Minor
@remix-run/architect Minor
@remix-run/cloudflare Minor
@remix-run/cloudflare-pages Minor
@remix-run/cloudflare-workers Minor
@remix-run/css-bundle Minor
@remix-run/deno Minor
@remix-run/eslint-config Minor
@remix-run/express Minor
@remix-run/netlify Minor
@remix-run/node Minor
@remix-run/react Minor
@remix-run/serve Minor
@remix-run/server-runtime Minor
@remix-run/testing Minor
@remix-run/vercel Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

This was referenced Jul 12, 2023
Closed
Closed
@markdalgleish markdalgleish merged commit cdb1d32 into dev Jul 13, 2023
@markdalgleish markdalgleish deleted the markdalgleish/server-polyfills-option branch July 13, 2023 00:32
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jul 13, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-cdb1d32-20230713 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

tygern added a commit to tygern/remix-otel-issue that referenced this pull request Jul 13, 2023
@tygern
Update remix to 0.0.0-nightly-cdb1d32-20230713 to pull in fix from re…
fba3408 
…mix-run/remix#6814
@tygern tygern mentioned this pull request Jul 13, 2023
Closed
@github-actions github-actions bot mentioned this pull request Jul 13, 2023
Merged
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.19.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot mentioned this pull request Jul 19, 2023
Merged
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.19.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacob-ebey jacob-ebey jacob-ebey approved these changes

Assignees
No one assigned
Labels
CLA Signed package:dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markdalgleish @jacob-ebey @LukeAskew