-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dev): better networking options #6724
Conversation
🦋 Changeset detectedLatest commit: 9511fb9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
486d74f
to
debfbb9
Compare
e9d1bd4
to
3273c23
Compare
4d589b0
to
12b2eb7
Compare
12b2eb7
to
9511fb9
Compare
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
Fixes #6718
Obsoletes #5467
Tested my running creating TLS key/cert for
myhost
and running:👆 Note that origin can omit the port since the default HTTPS port of 443 is used. Also tested with
tlsKey
andtlsCert
config options.Also tried with the same command without
REMIX_DEV_ORIGIN
to ensure that TLS protocols (https
/wss
) are correctly inferred from TLS flags and config options.Finally, also tested that
REMIX_DEV_SERVER_WS_PORT
works to set the ws port for the old dev server.TODO