Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): better networking options #6724

Merged
merged 5 commits into from
Jul 3, 2023
Merged

fix(dev): better networking options #6724

merged 5 commits into from
Jul 3, 2023

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented Jun 29, 2023

Fixes #6718
Obsoletes #5467

Tested my running creating TLS key/cert for myhost and running:

REMIX_DEV_ORIGIN=https://myhost remix dev --no-restart -c \"node server.js\" --tls-key=key.pem --tls-cert=cert.pem --port=443

👆 Note that origin can omit the port since the default HTTPS port of 443 is used. Also tested with tlsKey and tlsCert config options.

Also tried with the same command without REMIX_DEV_ORIGIN to ensure that TLS protocols (https/wss) are correctly inferred from TLS flags and config options.

Finally, also tested that REMIX_DEV_SERVER_WS_PORT works to set the ws port for the old dev server.

TODO

  • docs
  • changeset

@changeset-bot
Copy link

changeset-bot bot commented Jun 29, 2023

🦋 Changeset detected

Latest commit: 9511fb9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/dev Minor
@remix-run/react Minor
@remix-run/server-runtime Minor
create-remix Minor
@remix-run/testing Minor
@remix-run/cloudflare Minor
@remix-run/deno Minor
@remix-run/node Minor
@remix-run/cloudflare-pages Minor
@remix-run/cloudflare-workers Minor
@remix-run/architect Minor
@remix-run/express Minor
@remix-run/netlify Minor
@remix-run/serve Minor
@remix-run/vercel Minor
remix Minor
@remix-run/css-bundle Minor
@remix-run/eslint-config Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori pcattori linked an issue Jun 29, 2023 that may be closed by this pull request
1 task
@pcattori pcattori force-pushed the pedro/fix-dev-networking branch 2 times, most recently from e9d1bd4 to 3273c23 Compare June 29, 2023 20:58
@pcattori pcattori force-pushed the pedro/fix-dev-networking branch 2 times, most recently from 4d589b0 to 12b2eb7 Compare June 30, 2023 20:10
@pcattori pcattori merged commit d7c026d into dev Jul 3, 2023
@pcattori pcattori deleted the pedro/fix-dev-networking branch July 3, 2023 16:07
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jul 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-5ad8fa5-20230704 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.19.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.19.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheme not set to HTTPS when TLS config options are set in remix.config.js
1 participant