-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(dev): fix CLI test #6698
test(dev): fix CLI test #6698
Conversation
|
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
The
express
template in main now uses ESM which crashes this test. This is because the code in@remix-run/dev
that reads the config makes a special case whenNODE_ENV
is"test"
and attempts torequire
the config rather than importing it, so this is not an issue impacting consumers. As a quick fix, this PR switches to the CJSremix
template which still passes this test suite since it only asserts the presence of a couple of key files.