Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(dev): fix CLI test #6698

Merged
merged 1 commit into from
Jun 27, 2023
Merged

test(dev): fix CLI test #6698

merged 1 commit into from
Jun 27, 2023

Conversation

markdalgleish
Copy link
Member

@markdalgleish markdalgleish commented Jun 27, 2023

The express template in main now uses ESM which crashes this test. This is because the code in @remix-run/dev that reads the config makes a special case when NODE_ENV is "test" and attempts to require the config rather than importing it, so this is not an issue impacting consumers. As a quick fix, this PR switches to the CJS remix template which still passes this test suite since it only asserts the presence of a couple of key files.

@changeset-bot
Copy link

changeset-bot bot commented Jun 27, 2023

⚠️ No Changeset found

Latest commit: 1c5c108

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@markdalgleish markdalgleish marked this pull request as ready for review June 27, 2023 04:31
@markdalgleish markdalgleish merged commit a91ddce into dev Jun 27, 2023
@markdalgleish markdalgleish deleted the markdalgleish/fix-cli-test branch June 27, 2023 04:31
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jun 27, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-a91ddce-20230627 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

brophdawg11 pushed a commit that referenced this pull request Jun 29, 2023
brophdawg11 pushed a commit that referenced this pull request Jun 29, 2023
brophdawg11 pushed a commit that referenced this pull request Jun 29, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-0657c16-20230630 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.18.1-pre.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-7abaf9f-20230701 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.19.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.19.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant