Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with pathless layout routes beneath nested path segments #6649

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

brophdawg11
Copy link
Contributor

#4421 added a short circuit for checking for URL conflicts with pathless layout routes, but it is unintentionally also short circuiting the line that updates the route manifest to strip the parent path. Need to lift that up before the short circuit. Doesn't impact root pathless layout routes, only those that are nested underneath an existing path segment which we didn't have existing tests for.

Closes #6645

@changeset-bot
Copy link

changeset-bot bot commented Jun 20, 2023

🦋 Changeset detected

Latest commit: 5c64d5f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 linked an issue Jun 20, 2023 that may be closed by this pull request
1 task
@brophdawg11 brophdawg11 merged commit b5bfcd1 into dev Jun 20, 2023
@brophdawg11 brophdawg11 deleted the brophdawg11/fix-nested-pathless-flat-routes branch June 20, 2023 20:32
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jun 20, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-ccefed3-20230621 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.18.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.18.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pathless layouts issue with v2 routing on 1.17.1
1 participant