Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix expires in createSessionStorage #6598

Merged
merged 8 commits into from
Aug 25, 2023

Conversation

naveed-fida
Copy link
Contributor

Closes: #6594

  • Docs
  • Tests

Testing Strategy:

A file existed already for testing sessions. I simply added a couple of tests that tests if the expires field gets added to the temp file created for the session store. Read the issue page for the details of the bug.

@changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2023

⚠️ No Changeset found

Latest commit: 8312843

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 13, 2023

Hi @naveed-fida,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 13, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@naveed-fida naveed-fida changed the title Bugfix for Issue #6594 fix(dev): closes Issue #6594 Jun 13, 2023
@brophdawg11 brophdawg11 changed the title fix(dev): closes Issue #6594 fix(dev): Fix bug with expires in createSessionStorage Jul 10, 2023
@brophdawg11 brophdawg11 added the feat:sessions Sessions related issues label Jul 10, 2023
@brophdawg11 brophdawg11 self-assigned this Aug 24, 2023
@brophdawg11
Copy link
Contributor

Thanks!

@brophdawg11 brophdawg11 merged commit efdfa9c into remix-run:dev Aug 25, 2023
9 checks passed
brophdawg11 added a commit that referenced this pull request Aug 25, 2023
@MichaelDeBoey MichaelDeBoey changed the title fix(dev): Fix bug with expires in createSessionStorage fix: fix expires in createSessionStorage Aug 26, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-f77588e-20230826 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants