Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dev): add BrowserMeta file for @remix-run/dev #6441

Closed
wants to merge 19 commits into from

Conversation

19Qingfeng
Copy link

@19Qingfeng 19Qingfeng commented May 20, 2023

Closes: #6416

  • Docs
  • Tests

I opened up my may machine and ran this script:

  1. Create a playgroud project, modify metafile: true in remix.config.js, and run npm run build to compile remix-run project.
    After that, look at debugDirectory(public/.debugger) to get the js-metafile.json file.

  2. Create a playgroud project, modify metafile: true and debugDirectory: ".debugger" in remix.config.js, and run npm run build to compile remix-run project.
    After that, look at debugDirectory(.debugger) to get the js-metafile.json file.

  3. Create a playground project, execute remix build --metafile,then you will get js-metafile.json.

@changeset-bot
Copy link

changeset-bot bot commented May 20, 2023

⚠️ No Changeset found

Latest commit: 488763b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 20, 2023

Hi @19Qingfeng,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 20, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@pcattori
Copy link
Contributor

@19Qingfeng thank you for the PR!

I think the direction we want to go in is to have a --metafile option that produces the metafile(s) into a dedicated directory.
Maybe default to .debug/ and configurable with debugDirectory option in remix.config.js or something like that.

@19Qingfeng
Copy link
Author

@19Qingfeng thank you for the PR!

I think the direction we want to go in is to have a --metafile option that produces the metafile(s) into a dedicated directory. Maybe default to .debug/ and configurable with debugDirectory option in remix.config.js or something like that.

Okay, I will refer to your feedback to modify the parameter name and generation location. I will resubmit it later. Thank you.

@19Qingfeng
Copy link
Author

@19Qingfeng thank you for the PR!

I think the direction we want to go in is to have a --metafile option that produces the metafile(s) into a dedicated directory. Maybe default to .debug/ and configurable with debugDirectory option in remix.config.js or something like that.

@pcattori hello,pcattori.Now, this time with the metafile and debugDirectory parameters, I will update the test description later.

packages/remix-dev/config.ts Show resolved Hide resolved
packages/remix-dev/compiler/compiler.ts Outdated Show resolved Hide resolved
packages/remix-dev/compiler/utils/analyzer.ts Outdated Show resolved Hide resolved
packages/remix-dev/compiler/compiler.ts Outdated Show resolved Hide resolved
@19Qingfeng 19Qingfeng requested a review from pcattori May 24, 2023 16:48
@19Qingfeng
Copy link
Author

@pcattori hi, i updated the code and synchronized the description, please check the changes.

@19Qingfeng
Copy link
Author

@pcattori Can you provide some feedback? Perhaps I can make further modifications

@Doelfke
Copy link

Doelfke commented Jun 21, 2023

What's the status of this?

@19Qingfeng
Copy link
Author

What's the status of this?

I'm not sure what the remix team is thinking right now. If I have an idea, Maybe I can resolve the conflict and modify the code.

@pcattori
Copy link
Contributor

Superceded by #6772

@pcattori pcattori closed this Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants