-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dev): add BrowserMeta file for @remix-run/dev #6441
Conversation
|
Hi @19Qingfeng, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
add 19Qingfeng
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
@19Qingfeng thank you for the PR! I think the direction we want to go in is to have a |
Okay, I will refer to your feedback to modify the parameter name and generation location. I will resubmit it later. Thank you. |
@pcattori hello,pcattori.Now, this time with the metafile and debugDirectory parameters, I will update the test description later. |
@pcattori hi, i updated the code and synchronized the description, please check the changes. |
@pcattori Can you provide some feedback? Perhaps I can make further modifications |
What's the status of this? |
I'm not sure what the remix team is thinking right now. If I have an idea, Maybe I can resolve the conflict and modify the code. |
Superceded by #6772 |
Closes: #6416
I opened up my may machine and ran this script:
Create a playgroud project, modify
metafile: true
in remix.config.js, and runnpm run build
to compile remix-run project.After that, look at
debugDirectory
(public/.debugger
) to get thejs-metafile.json
file.Create a playgroud project, modify
metafile: true
anddebugDirectory: ".debugger"
in remix.config.js, and runnpm run build
to compile remix-run project.After that, look at
debugDirectory
(.debugger
) to get thejs-metafile.json
file.Create a playground project, execute
remix build --metafile
,then you will getjs-metafile.json
.