refactor(remix-server-runtime): expose SessionStorage's methods as arrow functions

[ngbrown]

Summary of changes

This is just the relevant parts of the code changes from #6325 instead of also tackling eslint-config changes.

• Expose methods in the SessionStorage interface as arrow functions so destructuring is correctly part of the contract.

Details

I attempted to add the typescript-eslint rules contained in "plugin:@typescript-eslint/recommended-requiring-type-checking" to a Remix based project and came across two common code issues:

const { pipe, abort } = renderToPipeableStream();

and then on:

const { getSession, commitSession, destroySession } = createDatabaseSessionStorage();

Both of these cause an unbound-method error:

error Avoid referencing unbound methods which may cause unintentional scoping of this.

If your function does not access this, you can annotate it with this: void, or consider using an arrow function instead @typescript-eslint/unbound-method

This error needed to be taken care of by the type definitions provided by the libraries.

@types/react-dom v18.2.4 now includes this: void in the functions returned from renderToPipeableStream(), so the first half is solved.

This pull request is to address the changes needed in Remix.

This could subtly change the contract for external libraries returning SessionStorage, so it would be good to get this in before Remix v2.

Testing Strategy:

I opened up my windows machine and ran this script:

yarn test:primary
npx playwrite install
yarn test
yarn build --tsc

Also tested on a Remix project with eslint and "plugin:@typescript-eslint/recommended-requiring-type-checking" enabled.

[changeset-bot]

🦋 Changeset detected

Latest commit: 45ac70c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages

Name	Type
@remix-run/server-runtime	Patch
@remix-run/cloudflare	Patch
@remix-run/deno	Patch
@remix-run/dev	Patch
@remix-run/node	Patch
@remix-run/react	Patch
@remix-run/cloudflare-pages	Patch
@remix-run/cloudflare-workers	Patch
create-remix	Patch
@remix-run/css-bundle	Patch
@remix-run/architect	Patch
@remix-run/express	Patch
@remix-run/netlify	Patch
@remix-run/serve	Patch
@remix-run/testing	Patch
@remix-run/vercel	Patch
remix	Patch
@remix-run/eslint-config	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[MichaelDeBoey]

Let's use arrow functions instead, as @JoshuaKGoldberg suggested in #6330 (comment)

[remix-cla-bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

[github-actions]

🤖 Hello there,

We just published version v0.0.0-nightly-360e77e-20230516 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version 1.16.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version 1.16.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!