Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): fix JSX in JS files with CSS imports #6309

Merged
merged 2 commits into from
May 5, 2023

Conversation

markdalgleish
Copy link
Member

Closes: #5331

This fixes an issue where the CSS side-effect imports plugin mistakenly assumed that JS files don't contain JSX, but this is out of step with the rest of Remix.

I've validated that .mjs and .cjs files don't support JSX in Remix, so this issue only affects JS files.

I've added a test to catch this, ensuring that the test fails against the latest code in dev.

@changeset-bot
Copy link

changeset-bot bot commented May 5, 2023

🦋 Changeset detected

Latest commit: 16d525e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/dev Patch
create-remix Patch
@remix-run/css-bundle Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish markdalgleish merged commit 6e23fcf into dev May 5, 2023
@markdalgleish markdalgleish deleted the markdalgleish/css-side-effects-in-js-with-jsx branch May 5, 2023 04:13
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-6e23fcf-20230505 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.16.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.16.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants