fix(dev): fix JSX in JS files with CSS imports #6309
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5331
This fixes an issue where the CSS side-effect imports plugin mistakenly assumed that JS files don't contain JSX, but this is out of step with the rest of Remix.
I've validated that
.mjs
and.cjs
files don't support JSX in Remix, so this issue only affects JS files.I've added a test to catch this, ensuring that the test fails against the latest code in dev.