[Bug] Test failing when loading api route

[alexbu92]

Testing Strategy:

The test describes an issue with loader revalidation that has come up in recent versions. This is the stack trace of the error:

Uncaught (in promise) Error: Expected route module to be loaded for routes/pizza
    at invariant2 (invariant.js:13:11)
    at Object.shouldRevalidate (routes.js:89:5)
    at shouldRevalidateLoader (router.ts:3383:41)
    at router.ts:3318:28
    at Map.forEach (<anonymous>)
    at getMatchesToLoad (router.ts:3278:20)
    at handleLoaders (router.ts:1458:49)
    at startNavigation (router.ts:1291:56)
    at Object.navigate (router.ts:1134:18)
    at hooks.tsx:965:16

It seems to be caused by using setSearchParams from the useSearchParams hook on a route where a useEffect uses a fetcher to load data from an api route.

In the test, if you comment out fetcher.load("/pizza") the test passes.
Also, if you poke the app and go to /burgers and look at the console you'll find the aforementioned error.

[changeset-bot]

⚠️ No Changeset found

Latest commit: eaf7ea3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[remix-cla-bot]

Hi @alexbu92,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

[remix-cla-bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

[brophdawg11]

This has to do with fetcher revalidation and has since been fixed.

remix-run/react-router#10623 (@remix-run/[email protected], [email protected], [email protected]) fixes the issue where fetchers would try to revalidate during their initial load which in Remix was often before their route module had loaded.

There is a small sub-optimization flow in [email protected] where these initial-loading-fetchers will revalidate uneccesarily, but that is fixed by remix-run/react-router#10688 in in @remix-run/[email protected], [email protected], and will soon be released in [email protected].