Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dev): unstable dev server improvements #6133

Merged
merged 16 commits into from
Apr 24, 2023
Merged

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented Apr 21, 2023

Fixes #5834 #5663 #5348 #5492

  • Fix for async error handling in compiler
  • Push-based app server synchronization (instead of polling)
  • App server as a managed subprocess

TODO

  • export ping function from @remix-run/dev that uses REMIX_DEV_HTTP_PORT env var to send updated build hash to dev server, then call that from app server
  • handle babel transform error in browser-route-module plugin
  • get HMR test passing (call ping in server from test fixture)
  • options to specify scheme/host/port for ping
  • changeset

Follow on work

@changeset-bot
Copy link

changeset-bot bot commented Apr 21, 2023

🦋 Changeset detected

Latest commit: a63e41c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/dev Minor
@remix-run/server-runtime Minor
create-remix Minor
@remix-run/css-bundle Minor
@remix-run/cloudflare Minor
@remix-run/deno Minor
@remix-run/node Minor
@remix-run/react Minor
@remix-run/cloudflare-pages Minor
@remix-run/cloudflare-workers Minor
@remix-run/architect Minor
@remix-run/express Minor
@remix-run/netlify Minor
@remix-run/serve Minor
@remix-run/testing Minor
@remix-run/vercel Minor
remix Minor
@remix-run/eslint-config Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori pcattori changed the title wip feat(dev): stabilize new dev server Apr 23, 2023
@pcattori pcattori changed the title feat(dev): stabilize new dev server feat(dev): pushed-based syncing between app and dev server Apr 24, 2023
@pcattori pcattori changed the title feat(dev): pushed-based syncing between app and dev server feat(dev): unstable dev server improvements Apr 24, 2023
@pcattori pcattori marked this pull request as ready for review April 24, 2023 17:29
@pcattori pcattori merged commit e6067b7 into dev Apr 24, 2023
@pcattori pcattori deleted the pedro/better-dev-server branch April 24, 2023 19:01
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Apr 24, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-6295eb6-20230425 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release This issue has been fixed and will be released soon CLA Signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants