Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: short circuit links and meta for routes that are not rendered due to errors #6107

Merged
merged 3 commits into from
Apr 25, 2023

Conversation

jacob-ebey
Copy link
Member

  • Visit a route with a meta export, but no ErrorBoundary
  • Throw a 404 in the route's loader
  • the meta function is called even though the route isn't going to be rendered

We should only call meta if the route's component or error boundary is going to be rendered.

Closes: #

  • Docs
  • Tests

Testing Strategy:

New integration tests

@changeset-bot
Copy link

changeset-bot bot commented Apr 19, 2023

🦋 Changeset detected

Latest commit: a6a5b3f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/react Patch
@remix-run/testing Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jacob-ebey jacob-ebey merged commit 2f008d0 into dev Apr 25, 2023
@jacob-ebey jacob-ebey deleted the link-meta-short-circuit branch April 25, 2023 22:38
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release This issue has been fixed and will be released soon CLA Signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants